commit cb79ddf448252ae8d25b8f0cb4e3dc4d7b8f54fe
author Antonio Maiorano <amaiorano@google.com> Wed Jun 12 00:37:29 2024 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Jun 12 00:37:29 2024 +0000
tree 551a424364832c4114fc94a0120fc49ac147a1ca
parent 0a29eaab20ec0f64fcc3d5c3266eea48bc0cd224

dawn/dxc: disable DXC pass 'structurize-loop-exits-for-unroll'

Multiple security bugs have been reported related to this optimization pass, and after careful consideration, we have decided to disable it.

Bug: chromium:333508731
Bug: chromium:339171223
Bug: chromium:339169163
Bug: chromium:346595893
Change-Id: I5c9d7180ed09e7417c120595937bcb1013b6ce66
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/184422
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
Reviewed-by: Natalie Chouinard <chouinard@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>

src/dawn/native/d3d/ShaderUtils.cpp

diff --git a/src/dawn/native/d3d/ShaderUtils.cpp b/src/dawn/native/d3d/ShaderUtils.cpp
index 89c0b19..a96cb88 100644
--- a/src/dawn/native/d3d/ShaderUtils.cpp
+++ b/src/dawn/native/d3d/ShaderUtils.cpp
@@ -58,6 +58,10 @@
     arguments.push_back(L"-E");
     arguments.push_back(entryPointNameW.data());
 
+    // TODO(chromium:346595893): Disable buggy DXC pass
+    arguments.push_back(L"-opt-disable");
+    arguments.push_back(L"structurize-loop-exits-for-unroll");
+
     uint32_t compileFlags = r.compileFlags;
     if (compileFlags & D3DCOMPILE_ENABLE_BACKWARDS_COMPATIBILITY) {
         arguments.push_back(L"/Gec");