commit d28b578b6b0927d79ebee58e407031dff3b93d9f
author Yunchao He <yunchao.he@intel.com> Thu Dec 19 18:50:18 2019 +0000
committer Commit Bot service account <commit-bot@chromium.org> Thu Dec 19 18:50:18 2019 +0000
tree 0d1b82d6e35683177bdbbec5cf4d8d873c5ca3b4
parent bfb2a5740fdbe3df6c7e7cacb7f635eeb98cc5e6

Disallow storage buffer binding in vertex shader

Writable storage buffer in vertex shader is an optional feature.
It is not supported in many devices/OSes. WebGPU doesn't support
writable storage buffer in vertex shader. This change generates an
error for storage buffer binding for vertex shader stage, in order
to disallow writable storage buffer in vertex shader.

This change also adds a validation test and revises existing
end2end tests and validation tests accordingly.

BUG=dawn:180

Change-Id: I9def918d19f65aab45a31acb985c1a0a09c97ca8
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/14521
Commit-Queue: Yunchao He <yunchao.he@intel.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>

src/tests/end2end/GpuMemorySynchronizationTests.cpp

diff --git a/src/tests/end2end/GpuMemorySynchronizationTests.cpp b/src/tests/end2end/GpuMemorySynchronizationTests.cpp
index 2917ee8..995d272 100644
--- a/src/tests/end2end/GpuMemorySynchronizationTests.cpp
+++ b/src/tests/end2end/GpuMemorySynchronizationTests.cpp
@@ -179,7 +179,7 @@
     pass0.Draw(1, 1, 0, 0);
     pass0.EndPass();
 
-    // Read that data in render pass.
+    // Read that data in compute pass.
     wgpu::ComputePassEncoder pass1 = encoder.BeginComputePass();
     pass1.SetPipeline(compute);
     pass1.SetBindGroup(0, bindGroup1);
@@ -210,7 +210,7 @@
 
     wgpu::CommandEncoder encoder = device.CreateCommandEncoder();
 
-    // Write data into a storage buffer in render pass.
+    // Write data into a storage buffer in compute pass.
     wgpu::ComputePassEncoder pass0 = encoder.BeginComputePass();
     pass0.SetPipeline(compute);
     pass0.SetBindGroup(0, bindGroup1);