Remove doxygen from kokoro build
This CL updates the kokoro build to no-longer build doxygen. The utility
of this check has gone down as we've run into many instances of doxygen
"finding" undocumented items that it didn't warn about previously. So,
it's very easy to have a CL blocked on doxygen failing due to existing
code. This makes committing much more difficult as it blocks the Kokoro
runs from completing.
Change-Id: I5e19f065716bc97a6a7b8965d54279b56f022369
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/172780
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
diff --git a/infra/kokoro/linux/docker.sh b/infra/kokoro/linux/docker.sh
index 7a1c5a5..6d7488d 100755
--- a/infra/kokoro/linux/docker.sh
+++ b/infra/kokoro/linux/docker.sh
@@ -92,7 +92,6 @@
using depot_tools
using go-1.18
-using doxygen-1.9.5
status "Creating source directory '${SRC_DIR}' and build directory '${BUILD_DIR}'"
mkdir -p ${SRC_DIR}
@@ -133,7 +132,7 @@
COMMON_CMAKE_FLAGS=""
COMMON_CMAKE_FLAGS+=" -DCMAKE_BUILD_TYPE=${BUILD_TYPE}"
- COMMON_CMAKE_FLAGS+=" -DTINT_DOCS_WARN_AS_ERROR=1"
+ COMMON_CMAKE_FLAGS+=" -DTINT_BUILD_DOCS=0"
COMMON_CMAKE_FLAGS+=" -DTINT_BUILD_BENCHMARKS=1"
COMMON_CMAKE_FLAGS+=" -DTINT_BUILD_SPV_READER=1"
COMMON_CMAKE_FLAGS+=" -DTINT_BUILD_WGSL_READER=1"
@@ -169,17 +168,6 @@
cd ${BUILD_DIR}
- status "Running Doxygen"
- echo "NOTE: This will fail on first warning. Run with -DTINT_DOCS_WARN_AS_ERROR=OFF to see all warnings".
- echo ""
- show_cmds
- # NOTE: If we upgrade Doxygen to a more recent version, we can set DOXYGEN_WARN_AS_ERROR to
- # "FAIL_ON_WARNINGS" instead of "YES" in our CMakeLists.txt so see all warnings, and then
- # fail. See https://www.doxygen.nl/manual/config.html#cfg_warn_as_error
- cmake ${SRC_DIR} ${CMAKE_FLAGS} ${COMMON_CMAKE_FLAGS}
- cmake --build . --target tint-docs
- hide_cmds
-
status "Building dawn in '${BUILD_DIR}'"
show_cmds
cmake ${SRC_DIR} ${CMAKE_FLAGS} ${COMMON_CMAKE_FLAGS}
