[dawn][native] Cleanup a few "bindless" TODOs.
They have been handled already.
Bug: 435317394
Change-Id: I7fc789c18cf06ce69895a0651ca66e6c47de2958
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/260354
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: dan sinclair <dsinclair@chromium.org>
diff --git a/src/dawn/native/vulkan/BindGroupLayoutVk.cpp b/src/dawn/native/vulkan/BindGroupLayoutVk.cpp
index c64c60d..d6e380d 100644
--- a/src/dawn/native/vulkan/BindGroupLayoutVk.cpp
+++ b/src/dawn/native/vulkan/BindGroupLayoutVk.cpp
@@ -370,11 +370,7 @@
mStaticDescriptorCountPerType = std::move(staticBindings.descriptorCountPerType);
std::vector<VkDescriptorSetLayoutBinding> bindings = std::move(staticBindings.bindings);
- // TODO(https://crbug.com/435317394): Add the storage buffer that will be used for availability
- // information.
-
// Add the last binding, which is the dynamic array.
- // TODO(https://crbug.com/435317394): Used a packed index instead of the BindingNumber here.
VkDescriptorSetLayoutBinding dynamicArray{
.binding = uint32_t(GetDynamicArrayStart()),
.descriptorType = VulkanDescriptorType(GetDynamicArrayKind()),
diff --git a/src/dawn/tests/unittests/validation/DynamicBindingArrayValidationTests.cpp b/src/dawn/tests/unittests/validation/DynamicBindingArrayValidationTests.cpp
index 1872c2c..2c11e98 100644
--- a/src/dawn/tests/unittests/validation/DynamicBindingArrayValidationTests.cpp
+++ b/src/dawn/tests/unittests/validation/DynamicBindingArrayValidationTests.cpp
@@ -1007,15 +1007,8 @@
// TODO(https://crbug.com/435317394): Add tests with additional DynamicBindingKind.
}
-// TODO(https://crbug.com/435317394): Add tests for the DynamicArrayKind. It is not possible to do
-// it at the moment because we cannot reflect DynamicArrayKind::Undefined (would require referencing
-// but not indexing the array) or any value that's not DynamicArrayKind::SampledTexture (no support
-// in Dawn or Tint for other cases). Tests to add after that are:
-// - The kind in the layout must match the deduced kind for the shader.
-// - Case with a resource_binding
-// - An error is produced at shader module compilation time if it uses the same resource_binding
-// with different DynamicArrayKinds.
-//
+// TODO(https://crbug.com/435317394): Add tests for an error being produced at shader module
+// compilation time if it uses the same resource_binding with different DynamicArrayKinds.
// Test that BGL defaulting works with dynamic binding arrays.
TEST_F(DynamicBindingArrayTests, GetBGLSuccess) {
