commit e5f014098bf1706bbf04f5a507ee8b8d04cbfba5
author Ben Clayton <bclayton@google.com> Wed Nov 15 12:34:48 2023 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Nov 15 12:34:48 2023 +0000
tree 92157ed3168057dbfdca0deed3285436bf8b6dfe
parent eb2a83df3c425b7feb63703b9597ff290bb4ce69

[msl] Remove PixelLocal as printer supported extension

At this point in the pipeline, it should have been transformed into a framebuffer-fetch.

Bug: tint:2085
Change-Id: If3da836395ffd755c2ef1d677cf096714b7ec10b
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/160840
Auto-Submit: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: dan sinclair <dsinclair@chromium.org>
Commit-Queue: dan sinclair <dsinclair@chromium.org>

src/tint/lang/msl/writer/ast_printer/ast_printer.cc

diff --git a/src/tint/lang/msl/writer/ast_printer/ast_printer.cc b/src/tint/lang/msl/writer/ast_printer/ast_printer.cc
index 60f7f81..a02c250 100644
--- a/src/tint/lang/msl/writer/ast_printer/ast_printer.cc
+++ b/src/tint/lang/msl/writer/ast_printer/ast_printer.cc
@@ -274,10 +274,11 @@
     if (!tint::wgsl::CheckSupportedExtensions(
             "MSL", builder_.AST(), diagnostics_,
             Vector{
+                // Note: kChromiumExperimentalPixelLocal should have been transformed into
+                // kChromiumExperimentalFramebufferFetch by the PixelLocal transform.
                 wgsl::Extension::kChromiumDisableUniformityAnalysis,
                 wgsl::Extension::kChromiumExperimentalDp4A,
                 wgsl::Extension::kChromiumExperimentalFullPtrParameters,
-                wgsl::Extension::kChromiumExperimentalPixelLocal,
                 wgsl::Extension::kChromiumExperimentalReadWriteStorageTexture,
                 wgsl::Extension::kChromiumExperimentalSubgroups,
                 wgsl::Extension::kChromiumExperimentalFramebufferFetch,