commit e7d39dc0c08522f046a53582bfa9f366e955ba89
author Zhaoming Jiang <zhaoming.jiang@microsoft.com> Wed May 21 21:31:15 2025 -0700
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed May 21 21:31:15 2025 -0700
tree 10b4012f8a1f9c4bf49a542de43cbc5dab244fe5
parent 598a6bdb89cb528455dd5f1c3617ad13bc8e5399

Dawn: Only check ACPI ids for Qualcomm D3D12 depth24plus-stencil8 workaround

This CL make the Qaulcomm depth24plus-stencil8 workaround only check
ACPI ids on D3D12 backends, since the Qualcomm D3D12 drivers only report
ACPI ids.

Bug: 411268750
Change-Id: Iac9df090d18f440cd5e3adf46355a9c1b5cd2126
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/242654
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Rafael Cintron <rafael.cintron@microsoft.com>
Commit-Queue: Zhaoming Jiang <zhaoming.jiang@microsoft.com>

src/dawn/native/d3d12/PhysicalDeviceD3D12.cpp

diff --git a/src/dawn/native/d3d12/PhysicalDeviceD3D12.cpp b/src/dawn/native/d3d12/PhysicalDeviceD3D12.cpp
index 908641e..eaf6c1a 100644
--- a/src/dawn/native/d3d12/PhysicalDeviceD3D12.cpp
+++ b/src/dawn/native/d3d12/PhysicalDeviceD3D12.cpp
@@ -823,9 +823,10 @@
     }
 
     // Use packed DXGI_FORMAT_D24_UNORM_S8_UINT format on Qualcomm devices to workaround texture
-    // loading/sampling issues for depth24plus-stencil8 texture.
+    // loading/sampling issues for depth24plus-stencil8 texture. Note that Qualcomm D3D12 drivers
+    // only report ACPI ids.
     // See https://crbug.com/411268750 for more information.
-    if (gpu_info::IsQualcomm_ACPI(vendorId) || gpu_info::IsQualcomm_PCI(vendorId)) {
+    if (gpu_info::IsQualcomm_ACPI(vendorId)) {
         deviceToggles->Default(Toggle::UsePackedDepth24UnormStencil8Format, true);
     }