Cleanup clang-tidy issues in src/tint/api
This CL fixes various clang-tidy warngings from the src/tint/api folder.
Change-Id: If607a5fc4660b82985372e91a4faa2862af832b9
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/192940
Reviewed-by: James Price <jrprice@google.com>
Commit-Queue: dan sinclair <dsinclair@chromium.org>
diff --git a/.clang-tidy b/.clang-tidy
index 5c446be..38eb60a 100644
--- a/.clang-tidy
+++ b/.clang-tidy
@@ -55,6 +55,7 @@
-cppcoreguidelines-init-variables,\
-cppcoreguidelines-interfaces-global-init,\
-cppcoreguidelines-macro-usage,\
+ -cppcoreguidelines-missing-std-forward,\
-cppcoreguidelines-narrowing-conversions,\
-cppcoreguidelines-no-malloc,\
-cppcoreguidelines-non-private-member-variables-in-classes,\
diff --git a/src/tint/api/common/binding_point.h b/src/tint/api/common/binding_point.h
index 8a76382..93cc343 100644
--- a/src/tint/api/common/binding_point.h
+++ b/src/tint/api/common/binding_point.h
@@ -54,19 +54,19 @@
/// Equality operator
/// @param rhs the BindingPoint to compare against
/// @returns true if this BindingPoint is equal to `rhs`
- inline bool operator==(const BindingPoint& rhs) const {
+ bool operator==(const BindingPoint& rhs) const {
return group == rhs.group && binding == rhs.binding;
}
/// Inequality operator
/// @param rhs the BindingPoint to compare against
/// @returns true if this BindingPoint is not equal to `rhs`
- inline bool operator!=(const BindingPoint& rhs) const { return !(*this == rhs); }
+ bool operator!=(const BindingPoint& rhs) const { return !(*this == rhs); }
/// Less-than operator
/// @param rhs the BindingPoint to compare against
/// @returns true if this BindingPoint comes before @p rhs
- inline bool operator<(const BindingPoint& rhs) const {
+ bool operator<(const BindingPoint& rhs) const {
if (group < rhs.group) {
return true;
}
@@ -97,8 +97,8 @@
public:
/// @param binding_point the binding point to create a hash for
/// @return the hash value
- inline size_t operator()(const tint::BindingPoint& binding_point) const {
- return static_cast<size_t>(binding_point.group) << 16 |
+ size_t operator()(const tint::BindingPoint& binding_point) const {
+ return (static_cast<size_t>(binding_point.group) << 16) |
static_cast<size_t>(binding_point.binding);
}
};
diff --git a/src/tint/api/tint.cc b/src/tint/api/tint.cc
index 07254b2..12e47e6 100644
--- a/src/tint/api/tint.cc
+++ b/src/tint/api/tint.cc
@@ -31,6 +31,7 @@
// The following includes are used by './tools/run gen' to add an implicit
// dependency from 'tint/api' to the libraries used to make up the Tint API.
////////////////////////////////////////////////////////////////////////////////
+// IWYU pragma: begin_keep
#include "src/tint/api/common/override_id.h"
#if TINT_BUILD_GLSL_WRITER
@@ -61,6 +62,8 @@
#include "src/tint/lang/wgsl/writer/writer.h" // nogncheck
#endif
+// IWYU pragma: end_keep
+
namespace tint {
/// Initialize initializes the Tint library. Call before using the Tint API.
diff --git a/src/tint/utils/reflection/reflection.h b/src/tint/utils/reflection/reflection.h
index 678727a..3abb825 100644
--- a/src/tint/utils/reflection/reflection.h
+++ b/src/tint/utils/reflection/reflection.h
@@ -33,9 +33,7 @@
#include <type_traits>
#include <utility>
-#include "src/tint/utils/macros/concat.h"
#include "src/tint/utils/macros/foreach.h"
-#include "src/tint/utils/math/math.h"
#include "src/tint/utils/memory/aligned_storage.h"
#include "src/tint/utils/result/result.h"
