commit e99ad765ae310769486f5a4aa1c1027d71fbf5a6
author shrekshao <shrekshao@google.com> Tue Sep 28 20:15:52 2021 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Sep 28 20:15:52 2021 +0000
tree e75c5539196e7dd47d10dbd5e74b42aa32bd63a6
parent 6e57843e67f2f1eb7cd77cdc02b92eb8726f72e0

Overridable constants vulkan implementation and tests

Add vulkan backend implementations and tests.
Disabled some tests that fail due to tint missing
features and issues.

Bug: dawn:1041, tint:1155
Change-Id: Iac161317450cff59627e08b1228bffde4cef71da
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/64981
Commit-Queue: Shrek Shao <shrekshao@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

src/dawn_native/ComputePipeline.cpp

diff --git a/src/dawn_native/ComputePipeline.cpp b/src/dawn_native/ComputePipeline.cpp
index 8360b56..f789235 100644
--- a/src/dawn_native/ComputePipeline.cpp
+++ b/src/dawn_native/ComputePipeline.cpp
@@ -30,9 +30,10 @@
             DAWN_TRY(device->ValidateObject(descriptor->layout));
         }
 
-        return ValidateProgrammableStage(device, descriptor->compute.module,
-                                         descriptor->compute.entryPoint, descriptor->layout,
-                                         SingleShaderStage::Compute);
+        return ValidateProgrammableStage(
+            device, descriptor->compute.module, descriptor->compute.entryPoint,
+            descriptor->compute.constantCount, descriptor->compute.constants, descriptor->layout,
+            SingleShaderStage::Compute);
     }
 
     // ComputePipelineBase
@@ -43,7 +44,8 @@
                        descriptor->layout,
                        descriptor->label,
                        {{SingleShaderStage::Compute, descriptor->compute.module,
-                         descriptor->compute.entryPoint}}) {
+                         descriptor->compute.entryPoint, descriptor->compute.constantCount,
+                         descriptor->compute.constants}}) {
     }
 
     ComputePipelineBase::ComputePipelineBase(DeviceBase* device, ObjectBase::ErrorTag tag)