commit ee3f7fad742fec0b4b801b8a3f16a53f90342cdb
author Ben Clayton <bclayton@google.com> Thu Jul 13 00:09:11 2023 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Jul 13 00:09:11 2023 +0000
tree d059496127ae6f796b019efff50f6422aae04aed
parent 44266d59c84fa5bc4c36112b1eb81b5686587a6a

[tint][fuzzers] Fix bug in tint_common_fuzzer.cc

ApplySubstituteOverrides() returns the (potentially) transformed function.
We need to move this back to `program` for it to be used.

Change-Id: I467e7255e877c7b230f50564ae9f0cc4201c209b
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/140998
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: James Price <jrprice@google.com>
Auto-Submit: Ben Clayton <bclayton@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>

src/tint/fuzzers/tint_common_fuzzer.cc

diff --git a/src/tint/fuzzers/tint_common_fuzzer.cc b/src/tint/fuzzers/tint_common_fuzzer.cc
index dad9e5f..62cd0ab 100644
--- a/src/tint/fuzzers/tint_common_fuzzer.cc
+++ b/src/tint/fuzzers/tint_common_fuzzer.cc
@@ -228,17 +228,15 @@
     if (transform_manager_) {
         transform::DataMap outputs;
         auto out = transform_manager_->Run(&program, *transform_inputs_, outputs);
-        if (!validate_program(out)) {
+        if (!validate_program(out)) {  // Will move: program <- out on success
             return 0;
         }
     }
 
-    {
-        // Run SubstituteOverride if required
-        auto out = ApplySubstituteOverrides(std::move(program));
-        if (!out.IsValid()) {
-            return 0;
-        }
+    // Run SubstituteOverride if required
+    program = ApplySubstituteOverrides(std::move(program));
+    if (!program.IsValid()) {
+        return 0;
     }
 
     // For the generates which use MultiPlanar, make sure the configuration options are provided so