commit f0b4dbb82dcde3e9ea152a459a5865bc3d93b3dc
author Ben Clayton <bclayton@google.com> Tue Feb 21 21:05:28 2023 +0000
committer Ben Clayton <bclayton@chromium.org> Tue Feb 21 21:05:28 2023 +0000
tree 2977cb1006177cabf96844ffe2a7f73e25b2a2ac
parent 650426b18793286cc2d11555d5ca0c32cd4e1106

tint: Resolve @interpolate() args as expressions

This CL makes the builtin argument resolve as a shadowable enumerator
expression.

Bug: tint:1841
Bug: tint:1845
Change-Id: I5000ea91771fabb460c80c164bc7708fbbb0288c
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/120722
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>

src/tint/resolver/dependency_graph.cc

diff --git a/src/tint/resolver/dependency_graph.cc b/src/tint/resolver/dependency_graph.cc
index a764596..e913789 100644
--- a/src/tint/resolver/dependency_graph.cc
+++ b/src/tint/resolver/dependency_graph.cc
@@ -438,6 +438,11 @@
                 TraverseValueExpression(id->expr);
                 return true;
             },
+            [&](const ast::InterpolateAttribute* interpolate) {
+                TraverseExpression(interpolate->type, "interpolation type", "references");
+                TraverseExpression(interpolate->sampling, "interpolation sampling", "references");
+                return true;
+            },
             [&](const ast::LocationAttribute* loc) {
                 TraverseValueExpression(loc->expr);
                 return true;
@@ -505,6 +510,16 @@
                 graph_.resolved_identifiers.Add(from, ResolvedIdentifier(access));
                 return;
             }
+            if (auto i_type = builtin::ParseInterpolationType(s);
+                i_type != builtin::InterpolationType::kUndefined) {
+                graph_.resolved_identifiers.Add(from, ResolvedIdentifier(i_type));
+                return;
+            }
+            if (auto i_smpl = builtin::ParseInterpolationSampling(s);
+                i_smpl != builtin::InterpolationSampling::kUndefined) {
+                graph_.resolved_identifiers.Add(from, ResolvedIdentifier(i_smpl));
+                return;
+            }
 
             UnknownSymbol(to, from->source, use);
             return;
@@ -884,6 +899,12 @@
     if (auto addr = AddressSpace(); addr != builtin::AddressSpace::kUndefined) {
         return "address space '" + utils::ToString(addr) + "'";
     }
+    if (auto type = InterpolationType(); type != builtin::InterpolationType::kUndefined) {
+        return "interpolation type '" + utils::ToString(type) + "'";
+    }
+    if (auto smpl = InterpolationSampling(); smpl != builtin::InterpolationSampling::kUndefined) {
+        return "interpolation sampling '" + utils::ToString(smpl) + "'";
+    }
     if (auto fmt = TexelFormat(); fmt != builtin::TexelFormat::kUndefined) {
         return "texel format '" + utils::ToString(fmt) + "'";
     }