commit f14f73d2910c6622d33759855e4bdfa74439f81b
author Ryan Harrison <rharrison@chromium.org> Mon Oct 28 22:37:25 2024 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Oct 28 22:37:25 2024 +0000
tree c980b5aea3f3823c5931b1c0638bdb29da4f6abf
parent 45c20d246d2c99d93a249a797b4d65fef0572d2d

[tint][ir][val] Clean up tests to use utility functions

Fixes: 376025585
Change-Id: I1d51c99c94b2a368d32565963b328ce8a1ae5b73
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/212740
Commit-Queue: James Price <jrprice@google.com>
Auto-Submit: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: James Price <jrprice@google.com>

src/tint/lang/core/ir/validator_test.cc

diff --git a/src/tint/lang/core/ir/validator_test.cc b/src/tint/lang/core/ir/validator_test.cc
index a3352ec..0f77ee6 100644
--- a/src/tint/lang/core/ir/validator_test.cc
+++ b/src/tint/lang/core/ir/validator_test.cc
@@ -389,7 +389,7 @@
 }
 
 TEST_F(IR_ValidatorTest, Function_Param_BothLocationAndBuiltin) {
-    auto* f = b.Function("my_func", ty.void_(), Function::PipelineStage::kFragment);
+    auto* f = FragmentEntryPoint("my_func");
 
     auto* p = b.FunctionParam("my_param", ty.vec4<f32>());
     IOAttributes attr;
@@ -417,7 +417,7 @@
 }
 
 TEST_F(IR_ValidatorTest, Function_Param_Struct_BothLocationAndBuiltin) {
-    auto* f = b.Function("my_func", ty.void_(), Function::PipelineStage::kFragment);
+    auto* f = FragmentEntryPoint("my_func");
 
     IOAttributes attr;
     attr.builtin = BuiltinValue::kPosition;
@@ -613,7 +613,7 @@
 }
 
 TEST_F(IR_ValidatorTest, Function_Return_BothLocationAndBuiltin) {
-    auto* f = b.Function("my_func", ty.vec4<f32>(), Function::PipelineStage::kVertex);
+    auto* f = VertexEntryPoint("my_func");
     IOAttributes attr;
     attr.builtin = BuiltinValue::kPosition;
     attr.location = 0;
@@ -2222,8 +2222,7 @@
 
 TEST_F(IR_ValidatorTest, CallToEntryPointFunction) {
     auto* f = b.Function("f", ty.void_());
-    auto* g = b.Function("g", ty.void_(), Function::PipelineStage::kCompute,
-                         std::array<uint32_t, 3>({0, 0, 0}));
+    auto* g = ComputeEntryPoint("g");
 
     b.Append(f->Block(), [&] {
         b.Call(g);
@@ -3168,7 +3167,7 @@
         b.Return(func);
     });
 
-    auto* ep = b.Function("ep", ty.void_(), Function::PipelineStage::kFragment);
+    auto* ep = FragmentEntryPoint("ep");
     b.Append(ep->Block(), [&] {
         b.Call(func);
         b.Return(ep);
@@ -3209,7 +3208,7 @@
         b.Return(func);
     });
 
-    auto* ep = b.Function("ep", ty.void_(), Function::PipelineStage::kFragment);
+    auto* ep = FragmentEntryPoint("ep");
     b.Append(ep->Block(), [&] {
         b.Call(func);
         b.Return(ep);
@@ -3249,8 +3248,7 @@
         b.Return(func);
     });
 
-    auto* ep = b.Function("ep", ty.void_(), Function::PipelineStage::kCompute,
-                          std::array<uint32_t, 3>({0, 0, 0}));
+    auto* ep = ComputeEntryPoint("ep");
 
     b.Append(ep->Block(), [&] {
         b.Call(func);