commit f3bcd41e7e96b02875dc9893c6cf57821d472658
author Ben Clayton <bclayton@google.com> Tue Sep 05 16:33:10 2023 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Sep 05 16:33:10 2023 +0000
tree 277db576bd4a91ca3a7350507a85fd4b0963e23f
parent 89b98283a31c166cd31458350b6e0d1131bb13a5

[tint][hlsl] Fix validation on unix

Command line arguments are more explicitly passed on unix than windows. Unlike windows, trailing whitespace will become part of the argv strings passed to the program. DXC doesn't like this.

Change-Id: Iabba926fbc6428478ca06d08c1d2dad48abc719d
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/149703
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>

src/tint/lang/hlsl/validate/hlsl.cc

diff --git a/src/tint/lang/hlsl/validate/hlsl.cc b/src/tint/lang/hlsl/validate/hlsl.cc
index bbcde35..af19505 100644
--- a/src/tint/lang/hlsl/validate/hlsl.cc
+++ b/src/tint/lang/hlsl/validate/hlsl.cc
@@ -74,7 +74,7 @@
         // and dawn_native\d3d12\ShaderModuleD3D12.cpp (GetDXCArguments)
         auto res = dxc(
             "-T " + std::string(stage_prefix) + "_" + std::string(shader_model_version),  // Profile
-            "-HV 2018 ",                                       // Use HLSL 2018
+            "-HV 2018",                                        // Use HLSL 2018
             "-E " + ep.first,                                  // Entry point
             "/Zpr",                                            // D3DCOMPILE_PACK_MATRIX_ROW_MAJOR
             "/Gis",                                            // D3DCOMPILE_IEEE_STRICTNESS