commit f58ef99a152b54ec2a651c94ec272e0623e80885
author Peng Huang <penghuang@chromium.org> Fri Jan 13 18:30:21 2023 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Jan 13 18:30:21 2023 +0000
tree a03e5231b85515b422e1e5353efc95be89093b67
parent dd54f74de15dbee21d4e6071b6e4060309123034

Use std::move() for rvalues in SerialMap and SerialQueue

Change-Id: Iddaf8227cb76b823107997a740eb7563268ff859
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/116925
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Auto-Submit: Peng Huang <penghuang@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>

src/dawn/common/SerialMap.h

diff --git a/src/dawn/common/SerialMap.h b/src/dawn/common/SerialMap.h
index cd26099..6ada5d9 100644
--- a/src/dawn/common/SerialMap.h
+++ b/src/dawn/common/SerialMap.h
@@ -16,6 +16,7 @@
 #define SRC_DAWN_COMMON_SERIALMAP_H_
 
 #include <map>
+#include <utility>
 #include <vector>
 
 #include "dawn/common/SerialStorage.h"
@@ -54,7 +55,7 @@
 
 template <typename Serial, typename Value>
 void SerialMap<Serial, Value>::Enqueue(Value&& value, Serial serial) {
-    this->mStorage[serial].emplace_back(value);
+    this->mStorage[serial].emplace_back(std::move(value));
 }
 
 template <typename Serial, typename Value>
@@ -68,8 +69,8 @@
 template <typename Serial, typename Value>
 void SerialMap<Serial, Value>::Enqueue(std::vector<Value>&& values, Serial serial) {
     DAWN_ASSERT(values.size() > 0);
-    for (const Value& value : values) {
-        Enqueue(value, serial);
+    for (Value& value : values) {
+        Enqueue(std::move(value), serial);
     }
 }
 

src/dawn/common/SerialQueue.h

diff --git a/src/dawn/common/SerialQueue.h b/src/dawn/common/SerialQueue.h
index d3d4f4f..378952e 100644
--- a/src/dawn/common/SerialQueue.h
+++ b/src/dawn/common/SerialQueue.h
@@ -80,7 +80,7 @@
 void SerialQueue<Serial, Value>::Enqueue(std::vector<Value>&& values, Serial serial) {
     DAWN_ASSERT(values.size() > 0);
     DAWN_ASSERT(this->Empty() || this->mStorage.back().first <= serial);
-    this->mStorage.emplace_back(serial, values);
+    this->mStorage.emplace_back(serial, std::move(values));
 }
 
 #endif  // SRC_DAWN_COMMON_SERIALQUEUE_H_