commit f848af2dc2a4e9c2cb4bc782667af3453047d5ba
author Ben Clayton <bclayton@google.com> Fri Jul 28 16:37:32 2023 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Jul 28 16:37:32 2023 +0000
tree 4470dc7c57ae3596fca05d6e36468075cb18178b
parent bae54e71987e1a21265ac639cd35e5a81c2da97b

[tint] Separate out fatal macros from diagnostics

Many places where we assert, ICE or call other fatal macros there are no
diagnostic lists to append to. Regardless, a fatal error should not
happen in production, so handling these as standard diagnostics is
questionable.

Change-Id: I1ad4992586dee52ef2a58aa19e81083ae300aa96
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/143381
Reviewed-by: James Price <jrprice@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
Auto-Submit: Ben Clayton <bclayton@google.com>

src/tint/utils/text/symbol.cc

diff --git a/src/tint/utils/text/symbol.cc b/src/tint/utils/text/symbol.cc
index 7b51f7f..336083f 100644
--- a/src/tint/utils/text/symbol.cc
+++ b/src/tint/utils/text/symbol.cc
@@ -34,17 +34,17 @@
 Symbol& Symbol::operator=(Symbol&& o) = default;
 
 bool Symbol::operator==(const Symbol& other) const {
-    TINT_ASSERT_GENERATION_IDS_EQUAL_IF_VALID(Symbol, generation_id_, other.generation_id_);
+    TINT_ASSERT_GENERATION_IDS_EQUAL_IF_VALID(generation_id_, other.generation_id_);
     return val_ == other.val_;
 }
 
 bool Symbol::operator!=(const Symbol& other) const {
-    TINT_ASSERT_GENERATION_IDS_EQUAL_IF_VALID(Symbol, generation_id_, other.generation_id_);
+    TINT_ASSERT_GENERATION_IDS_EQUAL_IF_VALID(generation_id_, other.generation_id_);
     return val_ != other.val_;
 }
 
 bool Symbol::operator<(const Symbol& other) const {
-    TINT_ASSERT_GENERATION_IDS_EQUAL_IF_VALID(Symbol, generation_id_, other.generation_id_);
+    TINT_ASSERT_GENERATION_IDS_EQUAL_IF_VALID(generation_id_, other.generation_id_);
     return val_ < other.val_;
 }