commit f9960c14a66f09e1c1db4b6a8c7f5e5962d668d7
author Jim Blackler <jimblackler@google.com> Thu Jun 06 15:37:43 2024 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Jun 06 15:37:43 2024 +0000
tree 3ddb71a8bec63790a762ae498149fa0f9ba263f7
parent 07bdddbea8a2579ba91f7afbb4382faaa5bfedf6

Fix for Kotlin method parameters.

Methods with a default value of '0' did not get that default set.

Bug: 344830775
Change-Id: I49fac0d30c31d18c74f5191c3f3198ede8aa90ab
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/191620
Commit-Queue: Jim Blackler <jimblackler@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Alex Benton <bentonian@google.com>

generator/templates/art/api_kotlin_types.kt

diff --git a/generator/templates/art/api_kotlin_types.kt b/generator/templates/art/api_kotlin_types.kt
index 9383202..14f8103 100644
--- a/generator/templates/art/api_kotlin_types.kt
+++ b/generator/templates/art/api_kotlin_types.kt
@@ -77,7 +77,7 @@
         Short{{ '?' if optional }}{% if default_value %} = {{ default_value }}{% endif %}
     {%- elif type.name.get() in ['int', 'int32_t', 'uint32_t'] -%}
         Int
-        {%- if default_value -%}
+        {%- if default_value not in [None, undefined] -%}
             {%- if default_value is string and default_value.startswith('WGPU_') -%}
                 = {{ 'Constants.' + default_value | replace('WGPU_', '') }}
             {%- elif default_value == 'nullptr' -%}
@@ -90,7 +90,7 @@
         {% endif %}
     {%- elif type.name.get() in ['int64_t', 'uint64_t', 'size_t'] -%}
         Long
-        {%- if default_value %}
+        {%- if default_value not in [None, undefined] %}
             {%- if default_value is string and default_value.startswith('WGPU_') -%}
                 = {{ 'Constants.' + default_value | replace('WGPU_', '') }}
             {%- elif default_value == 'nullptr' -%}