[tint][resolver] Don't create throwaway sem::Parameters
Bug: tint:2129
Change-Id: I751aa82c7553d1bb6ee362d1affaefcc7b29904e
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/171663
Reviewed-by: James Price <jrprice@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: dan sinclair <dsinclair@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
diff --git a/src/tint/lang/wgsl/resolver/resolver.cc b/src/tint/lang/wgsl/resolver/resolver.cc
index 07de012..ea351a2 100644
--- a/src/tint/lang/wgsl/resolver/resolver.cc
+++ b/src/tint/lang/wgsl/resolver/resolver.cc
@@ -2131,10 +2131,11 @@
// Is this overload a constructor or conversion?
if (match->info->flags.Contains(OverloadFlag::kIsConstructor)) {
// Type constructor
- auto params = Transform(match->parameters, [&](auto& p, size_t i) {
- return b.create<sem::Parameter>(nullptr, static_cast<uint32_t>(i), p.type, p.usage);
- });
target_sem = constructors_.GetOrCreate(match.Get(), [&] {
+ auto params = Transform(match->parameters, [&](auto& p, size_t i) {
+ return b.create<sem::Parameter>(nullptr, static_cast<uint32_t>(i), p.type,
+ p.usage);
+ });
return b.create<sem::ValueConstructor>(match->return_type, std::move(params),
overload_stage);
});
