commit 3a3952c4f5924c4a76add45c13b265441d60f864
author Corentin Wallez <cwallez@chromium.org> Fri Jun 18 08:52:12 2021 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Jun 18 08:52:12 2021 +0000
tree acf3a44368056c984bff310af43359ea16ac1c00
parent aee22d142b961f411635ad94624eb4b00f5f9c3c

Suppress ShaderRobustnessPerf when using Tint + FXC

Also tighten previous suppressions to only apply when using the Tint
generator.

TBR=bclayton@google.com

Bug: tint:904
Change-Id: I22210227c428eb38901904966ec2c3bd70ce607b
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/55200
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

src/tests/end2end/VertexFormatTests.cpp

diff --git a/src/tests/end2end/VertexFormatTests.cpp b/src/tests/end2end/VertexFormatTests.cpp
index 1563a83..e735142 100644
--- a/src/tests/end2end/VertexFormatTests.cpp
+++ b/src/tests/end2end/VertexFormatTests.cpp
@@ -53,7 +53,7 @@
         DAWN_SUPPRESS_TEST_IF(IsMetal() && IsIntel());
 
         // TODO(crbug.com/tint/904): FXC emits bad output for this test
-        DAWN_SUPPRESS_TEST_IF(IsD3D12() && !IsDXC());
+        DAWN_SUPPRESS_TEST_IF(IsD3D12() && !IsDXC() && HasToggleEnabled("use_tint_generator"));
 
         renderPass = utils::CreateBasicRenderPass(device, kRTSize, kRTSize);
     }

src/tests/perf_tests/ShaderRobustnessPerf.cpp

diff --git a/src/tests/perf_tests/ShaderRobustnessPerf.cpp b/src/tests/perf_tests/ShaderRobustnessPerf.cpp
index ffcce8a..b180bc5 100644
--- a/src/tests/perf_tests/ShaderRobustnessPerf.cpp
+++ b/src/tests/perf_tests/ShaderRobustnessPerf.cpp
@@ -409,6 +409,9 @@
     // TODO(crbug.com/dawn/786): D3D12_Microsoft_Basic_Render_Driver_CPU
     DAWN_SUPPRESS_TEST_IF(IsD3D12() && IsWARP());
 
+    // TODO(crbug.com/tint/904): FXC emits bad output for this test
+    DAWN_SUPPRESS_TEST_IF(IsD3D12() && !IsDXC() && HasToggleEnabled("use_tint_generator"));
+
     const size_t dataASize = mDimAOuter * mDimInner;
     std::vector<float> dataA(dataASize);
     uint64_t byteASize = sizeof(float) * dataA.size();