commit 9dffe91f6a4f715007a2e949dfca94eb02077479
author Antonio Maiorano <amaiorano@google.com> Mon Aug 28 16:41:43 2023 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Aug 28 16:41:43 2023 +0000
tree ee7b36dcc8318f18af693531cb23307db9aa8a76
parent 4e33fe6b8a5327c33ef4df7567a8842a32b3a826

tint_cmd: force DXC to use HLSL 2018 like Dawn

The latest DXC changed the default to use HLSL 2021, which fails to
compile some of our e2e tests because of changes in how ternary
expressions with vectors work. Let's just do as Dawn does, and force DXC
to use HLSL 2018 rules.

Bug: tint:2018
Change-Id: I471a851afba8d5f8fc9e71262062c0ee96ffe8a3
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/148740
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>

src/tint/lang/hlsl/validate/hlsl.cc

diff --git a/src/tint/lang/hlsl/validate/hlsl.cc b/src/tint/lang/hlsl/validate/hlsl.cc
index 323885d..bbcde35 100644
--- a/src/tint/lang/hlsl/validate/hlsl.cc
+++ b/src/tint/lang/hlsl/validate/hlsl.cc
@@ -74,6 +74,7 @@
         // and dawn_native\d3d12\ShaderModuleD3D12.cpp (GetDXCArguments)
         auto res = dxc(
             "-T " + std::string(stage_prefix) + "_" + std::string(shader_model_version),  // Profile
+            "-HV 2018 ",                                       // Use HLSL 2018
             "-E " + ep.first,                                  // Entry point
             "/Zpr",                                            // D3DCOMPILE_PACK_MATRIX_ROW_MAJOR
             "/Gis",                                            // D3DCOMPILE_IEEE_STRICTNESS