commit 5063058c6b0f7ae3b076c15a4f303d538fe232be
author Corentin Wallez <cwallez@chromium.org> Wed Dec 06 17:45:33 2023 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Dec 06 17:45:33 2023 +0000
tree a41ba017c96058ea989a89e5c784f3c728236d08
parent 5990402210c025697293aee183fae0652de1de18

dawn.node: Throw TypeError on writeTimestamp

This method has been removed from the GPUCommandEncoder interface even
when "timestamp-query" is enabled.

Bug: None
Change-Id: I5ede13bd605999f85ffcf8f468a5671d39f8df7e
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/162720
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>

src/dawn/node/binding/GPUCommandEncoder.cpp

diff --git a/src/dawn/node/binding/GPUCommandEncoder.cpp b/src/dawn/node/binding/GPUCommandEncoder.cpp
index 5f50d07..35c102e 100644
--- a/src/dawn/node/binding/GPUCommandEncoder.cpp
+++ b/src/dawn/node/binding/GPUCommandEncoder.cpp
@@ -188,20 +188,10 @@
 void GPUCommandEncoder::writeTimestamp(Napi::Env env,
                                        interop::Interface<interop::GPUQuerySet> querySet,
                                        interop::GPUSize32 queryIndex) {
-    if (!device_.HasFeature(wgpu::FeatureName::TimestampQuery)) {
-        Napi::TypeError::New(env, "timestamp-query feature is not enabled.")
-            .ThrowAsJavaScriptException();
-        return;
-    }
-
-    Converter conv(env);
-
-    wgpu::QuerySet q{};
-    if (!conv(q, querySet)) {
-        return;
-    }
-
-    enc_.WriteTimestamp(q, queryIndex);
+    Napi::TypeError::New(
+        env, "writeTimestamp is no longer supported with the 'timestamp-query' feature.")
+        .ThrowAsJavaScriptException();
+    return;
 }
 
 void GPUCommandEncoder::resolveQuerySet(Napi::Env env,