commit 189ceb67037e7dc5e9b19ba0ba3b94d9e4d2c60a
author David Neto <dneto@google.com> Fri Nov 20 19:34:34 2020 +0000
committer Commit Bot service account <commit-bot@chromium.org> Fri Nov 20 19:34:34 2020 +0000
tree c2a5d328f035088dc38329a35a350fb50c5c4a84
parent ca03041ad7ff71823659755077ed21d13be2e495

Avoid floating point equality checks in tests

Make newer Apple clangs happy even with -Wfloat-equal

Change-Id: I186c03811b3ed582f740afd3f01ea09090e6b7e1
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/33600
Commit-Queue: David Neto <dneto@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
Auto-Submit: David Neto <dneto@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>

src/writer/float_to_string_test.cc

diff --git a/src/writer/float_to_string_test.cc b/src/writer/float_to_string_test.cc
index ca1a066..dda4554 100644
--- a/src/writer/float_to_string_test.cc
+++ b/src/writer/float_to_string_test.cc
@@ -43,8 +43,9 @@
 }
 
 TEST(FloatToStringTest, Highest) {
-  if (std::numeric_limits<float>::max() !=
-      340282346638528859811704183484516925440.0f) {
+  const auto highest = std::numeric_limits<float>::max();
+  const auto expected_highest = 340282346638528859811704183484516925440.0f;
+  if (highest < expected_highest || highest > expected_highest) {
     GTEST_SKIP() << "std::numeric_limits<float>::max() is not as expected for "
                     "this target";
   }
@@ -53,8 +54,11 @@
 }
 
 TEST(FloatToStringTest, Lowest) {
-  if (std::numeric_limits<float>::lowest() !=
-      -340282346638528859811704183484516925440.0f) {
+  // Some compilers complain if you test floating point numbers for equality.
+  // So say it via two inequalities.
+  const auto lowest = std::numeric_limits<float>::lowest();
+  const auto expected_lowest = -340282346638528859811704183484516925440.0f;
+  if (lowest < expected_lowest || lowest > expected_lowest) {
     GTEST_SKIP()
         << "std::numeric_limits<float>::lowest() is not as expected for "
            "this target";