commit 4e4cef90fec8ea0141868094c86156cc04d8b585
author David Neto <dneto@google.com> Mon Jul 26 18:09:59 2021 +0000
committer Tint LUCI CQ <tint-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Jul 26 18:09:59 2021 +0000
tree c31e1982ac9d615c7a84d95250c7223f21fcdf01
parent 1444a2e117285fd3b46e41ac1d9c9255020ba999

spirv-reader: disable dumping for known incorrectness

Bug: tint:1043, tint:1039
Change-Id: I6de89097d166df30bcf573ec77b9af6f09eb3d75
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/59483
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: James Price <jrprice@google.com>
Commit-Queue: James Price <jrprice@google.com>
Auto-Submit: David Neto <dneto@google.com>

src/reader/spirv/parser_impl_handle_test.cc

diff --git a/src/reader/spirv/parser_impl_handle_test.cc b/src/reader/spirv/parser_impl_handle_test.cc
index 116b7bc..74e48b2 100644
--- a/src/reader/spirv/parser_impl_handle_test.cc
+++ b/src/reader/spirv/parser_impl_handle_test.cc
@@ -260,6 +260,8 @@
   EXPECT_EQ(sampler, nullptr);
   EXPECT_EQ(image, nullptr);
   EXPECT_TRUE(p->error().empty());
+
+  p->DeliberatelyInvalidSpirv();  // WGSL does not have null pointers.
 }
 
 TEST_F(SpvParserHandleTest,
@@ -589,6 +591,8 @@
 
   ASSERT_TRUE(image != nullptr);
   EXPECT_EQ(image->result_id(), 20u);
+
+  p->SkipDumpingPending("crbug.com/tint/1039");
 }
 
 TEST_F(SpvParserHandleTest,
@@ -774,6 +778,8 @@
 
   ASSERT_TRUE(image != nullptr);
   EXPECT_EQ(image->result_id(), 20u);
+
+  p->SkipDumpingPending("crbug.com/tint/1039");
 }
 
 TEST_F(SpvParserHandleTest,
@@ -803,6 +809,8 @@
 
   ASSERT_TRUE(image != nullptr);
   EXPECT_EQ(image->result_id(), 20u);
+
+  p->SkipDumpingPending("crbug.com/tint/1039");
 }
 
 TEST_F(SpvParserHandleTest,
@@ -837,6 +845,8 @@
 
   ASSERT_TRUE(image != nullptr);
   EXPECT_EQ(image->result_id(), 20u);
+
+  p->SkipDumpingPending("crbug.com/tint/1039");
 }
 
 TEST_F(SpvParserHandleTest,
@@ -866,6 +876,8 @@
   const auto* image = p->GetMemoryObjectDeclarationForHandle(200, true);
   ASSERT_TRUE(image != nullptr);
   EXPECT_EQ(image->result_id(), 20u);
+
+  p->SkipDumpingPending("crbug.com/tint/1039");
 }
 
 // Test RegisterHandleUsage, sampled image cases