| // Copyright 2020 The Tint Authors. |
| // |
| // Licensed under the Apache License, Version 2.0 (the "License"); |
| // you may not use this file except in compliance with the License. |
| // You may obtain a copy of the License at |
| // |
| // http://www.apache.org/licenses/LICENSE-2.0 |
| // |
| // Unless required by applicable law or agreed to in writing, software |
| // distributed under the License is distributed on an "AS IS" BASIS, |
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| // See the License for the specific language governing permissions and |
| // limitations under the License. |
| |
| #include "src/transform/robustness.h" |
| |
| #include "src/transform/test_helper.h" |
| |
| namespace tint { |
| namespace transform { |
| namespace { |
| |
| using RobustnessTest = TransformTest; |
| |
| TEST_F(RobustnessTest, Ptrs_Clamp) { |
| auto* src = R"( |
| var<private> a : array<f32, 3>; |
| |
| let c : u32 = 1u; |
| |
| fn f() { |
| let b : f32 = a[c]; |
| } |
| )"; |
| |
| auto* expect = R"( |
| var<private> a : array<f32, 3>; |
| |
| let c : u32 = 1u; |
| |
| fn f() { |
| let b : f32 = a[min(u32(c), 2u)]; |
| } |
| )"; |
| |
| auto got = Run<Robustness>(src); |
| |
| EXPECT_EQ(expect, str(got)); |
| } |
| |
| TEST_F(RobustnessTest, Array_Idx_Nested_Scalar) { |
| auto* src = R"( |
| var<private> a : array<f32, 3>; |
| |
| var<private> b : array<i32, 5>; |
| |
| var<private> i : u32; |
| |
| fn f() { |
| var c : f32 = a[ b[i] ]; |
| } |
| )"; |
| |
| auto* expect = R"( |
| var<private> a : array<f32, 3>; |
| |
| var<private> b : array<i32, 5>; |
| |
| var<private> i : u32; |
| |
| fn f() { |
| var c : f32 = a[min(u32(b[min(u32(i), 4u)]), 2u)]; |
| } |
| )"; |
| |
| auto got = Run<Robustness>(src); |
| |
| EXPECT_EQ(expect, str(got)); |
| } |
| |
| TEST_F(RobustnessTest, Array_Idx_Scalar) { |
| auto* src = R"( |
| var<private> a : array<f32, 3>; |
| |
| fn f() { |
| var b : f32 = a[1]; |
| } |
| )"; |
| |
| auto* expect = R"( |
| var<private> a : array<f32, 3>; |
| |
| fn f() { |
| var b : f32 = a[1]; |
| } |
| )"; |
| |
| auto got = Run<Robustness>(src); |
| |
| EXPECT_EQ(expect, str(got)); |
| } |
| |
| TEST_F(RobustnessTest, Array_Idx_Expr) { |
| auto* src = R"( |
| var<private> a : array<f32, 3>; |
| |
| var<private> c : i32; |
| |
| fn f() { |
| var b : f32 = a[c + 2 - 3]; |
| } |
| )"; |
| |
| auto* expect = R"( |
| var<private> a : array<f32, 3>; |
| |
| var<private> c : i32; |
| |
| fn f() { |
| var b : f32 = a[min(u32(((c + 2) - 3)), 2u)]; |
| } |
| )"; |
| |
| auto got = Run<Robustness>(src); |
| |
| EXPECT_EQ(expect, str(got)); |
| } |
| |
| TEST_F(RobustnessTest, Array_Idx_Negative) { |
| auto* src = R"( |
| var<private> a : array<f32, 3>; |
| |
| fn f() { |
| var b : f32 = a[-1]; |
| } |
| )"; |
| |
| auto* expect = R"( |
| var<private> a : array<f32, 3>; |
| |
| fn f() { |
| var b : f32 = a[0]; |
| } |
| )"; |
| |
| auto got = Run<Robustness>(src); |
| |
| EXPECT_EQ(expect, str(got)); |
| } |
| |
| TEST_F(RobustnessTest, Array_Idx_OutOfBounds) { |
| auto* src = R"( |
| var<private> a : array<f32, 3>; |
| |
| fn f() { |
| var b : f32 = a[3]; |
| } |
| )"; |
| |
| auto* expect = R"( |
| var<private> a : array<f32, 3>; |
| |
| fn f() { |
| var b : f32 = a[2]; |
| } |
| )"; |
| |
| auto got = Run<Robustness>(src); |
| |
| EXPECT_EQ(expect, str(got)); |
| } |
| |
| TEST_F(RobustnessTest, Vector_Idx_Scalar) { |
| auto* src = R"( |
| var<private> a : vec3<f32>; |
| |
| fn f() { |
| var b : f32 = a[1]; |
| } |
| )"; |
| |
| auto* expect = R"( |
| var<private> a : vec3<f32>; |
| |
| fn f() { |
| var b : f32 = a[1]; |
| } |
| )"; |
| |
| auto got = Run<Robustness>(src); |
| |
| EXPECT_EQ(expect, str(got)); |
| } |
| |
| TEST_F(RobustnessTest, Vector_Idx_Expr) { |
| auto* src = R"( |
| var<private> a : vec3<f32>; |
| |
| var<private> c : i32; |
| |
| fn f() { |
| var b : f32 = a[c + 2 - 3]; |
| } |
| )"; |
| |
| auto* expect = R"( |
| var<private> a : vec3<f32>; |
| |
| var<private> c : i32; |
| |
| fn f() { |
| var b : f32 = a[min(u32(((c + 2) - 3)), 2u)]; |
| } |
| )"; |
| |
| auto got = Run<Robustness>(src); |
| |
| EXPECT_EQ(expect, str(got)); |
| } |
| |
| TEST_F(RobustnessTest, Vector_Swizzle_Idx_Scalar) { |
| auto* src = R"( |
| var<private> a : vec3<f32>; |
| |
| fn f() { |
| var b : f32 = a.xy[2]; |
| } |
| )"; |
| |
| auto* expect = R"( |
| var<private> a : vec3<f32>; |
| |
| fn f() { |
| var b : f32 = a.xy[1]; |
| } |
| )"; |
| |
| auto got = Run<Robustness>(src); |
| |
| EXPECT_EQ(expect, str(got)); |
| } |
| |
| TEST_F(RobustnessTest, Vector_Swizzle_Idx_Var) { |
| auto* src = R"( |
| var<private> a : vec3<f32>; |
| |
| var<private> c : i32; |
| |
| fn f() { |
| var b : f32 = a.xy[c]; |
| } |
| )"; |
| |
| auto* expect = R"( |
| var<private> a : vec3<f32>; |
| |
| var<private> c : i32; |
| |
| fn f() { |
| var b : f32 = a.xy[min(u32(c), 1u)]; |
| } |
| )"; |
| |
| auto got = Run<Robustness>(src); |
| |
| EXPECT_EQ(expect, str(got)); |
| } |
| TEST_F(RobustnessTest, Vector_Swizzle_Idx_Expr) { |
| auto* src = R"( |
| var<private> a : vec3<f32>; |
| |
| var<private> c : i32; |
| |
| fn f() { |
| var b : f32 = a.xy[c + 2 - 3]; |
| } |
| )"; |
| |
| auto* expect = R"( |
| var<private> a : vec3<f32>; |
| |
| var<private> c : i32; |
| |
| fn f() { |
| var b : f32 = a.xy[min(u32(((c + 2) - 3)), 1u)]; |
| } |
| )"; |
| |
| auto got = Run<Robustness>(src); |
| |
| EXPECT_EQ(expect, str(got)); |
| } |
| |
| TEST_F(RobustnessTest, Vector_Idx_Negative) { |
| auto* src = R"( |
| var<private> a : vec3<f32>; |
| |
| fn f() { |
| var b : f32 = a[-1]; |
| } |
| )"; |
| |
| auto* expect = R"( |
| var<private> a : vec3<f32>; |
| |
| fn f() { |
| var b : f32 = a[0]; |
| } |
| )"; |
| |
| auto got = Run<Robustness>(src); |
| |
| EXPECT_EQ(expect, str(got)); |
| } |
| |
| TEST_F(RobustnessTest, Vector_Idx_OutOfBounds) { |
| auto* src = R"( |
| var<private> a : vec3<f32>; |
| |
| fn f() { |
| var b : f32 = a[3]; |
| } |
| )"; |
| |
| auto* expect = R"( |
| var<private> a : vec3<f32>; |
| |
| fn f() { |
| var b : f32 = a[2]; |
| } |
| )"; |
| |
| auto got = Run<Robustness>(src); |
| |
| EXPECT_EQ(expect, str(got)); |
| } |
| |
| TEST_F(RobustnessTest, Matrix_Idx_Scalar) { |
| auto* src = R"( |
| var<private> a : mat3x2<f32>; |
| |
| fn f() { |
| var b : f32 = a[2][1]; |
| } |
| )"; |
| |
| auto* expect = R"( |
| var<private> a : mat3x2<f32>; |
| |
| fn f() { |
| var b : f32 = a[2][1]; |
| } |
| )"; |
| |
| auto got = Run<Robustness>(src); |
| |
| EXPECT_EQ(expect, str(got)); |
| } |
| |
| TEST_F(RobustnessTest, Matrix_Idx_Expr_Column) { |
| auto* src = R"( |
| var<private> a : mat3x2<f32>; |
| |
| var<private> c : i32; |
| |
| fn f() { |
| var b : f32 = a[c + 2 - 3][1]; |
| } |
| )"; |
| |
| auto* expect = R"( |
| var<private> a : mat3x2<f32>; |
| |
| var<private> c : i32; |
| |
| fn f() { |
| var b : f32 = a[min(u32(((c + 2) - 3)), 2u)][1]; |
| } |
| )"; |
| |
| auto got = Run<Robustness>(src); |
| |
| EXPECT_EQ(expect, str(got)); |
| } |
| |
| TEST_F(RobustnessTest, Matrix_Idx_Expr_Row) { |
| auto* src = R"( |
| var<private> a : mat3x2<f32>; |
| |
| var<private> c : i32; |
| |
| fn f() { |
| var b : f32 = a[1][c + 2 - 3]; |
| } |
| )"; |
| |
| auto* expect = R"( |
| var<private> a : mat3x2<f32>; |
| |
| var<private> c : i32; |
| |
| fn f() { |
| var b : f32 = a[1][min(u32(((c + 2) - 3)), 1u)]; |
| } |
| )"; |
| |
| auto got = Run<Robustness>(src); |
| |
| EXPECT_EQ(expect, str(got)); |
| } |
| |
| TEST_F(RobustnessTest, Matrix_Idx_Negative_Column) { |
| auto* src = R"( |
| var<private> a : mat3x2<f32>; |
| |
| fn f() { |
| var b : f32 = a[-1][1]; |
| } |
| )"; |
| |
| auto* expect = R"( |
| var<private> a : mat3x2<f32>; |
| |
| fn f() { |
| var b : f32 = a[0][1]; |
| } |
| )"; |
| |
| auto got = Run<Robustness>(src); |
| |
| EXPECT_EQ(expect, str(got)); |
| } |
| |
| TEST_F(RobustnessTest, Matrix_Idx_Negative_Row) { |
| auto* src = R"( |
| var<private> a : mat3x2<f32>; |
| |
| fn f() { |
| var b : f32 = a[2][-1]; |
| } |
| )"; |
| |
| auto* expect = R"( |
| var<private> a : mat3x2<f32>; |
| |
| fn f() { |
| var b : f32 = a[2][0]; |
| } |
| )"; |
| |
| auto got = Run<Robustness>(src); |
| |
| EXPECT_EQ(expect, str(got)); |
| } |
| |
| TEST_F(RobustnessTest, Matrix_Idx_OutOfBounds_Column) { |
| auto* src = R"( |
| var<private> a : mat3x2<f32>; |
| |
| fn f() { |
| var b : f32 = a[5][1]; |
| } |
| )"; |
| |
| auto* expect = R"( |
| var<private> a : mat3x2<f32>; |
| |
| fn f() { |
| var b : f32 = a[2][1]; |
| } |
| )"; |
| |
| auto got = Run<Robustness>(src); |
| |
| EXPECT_EQ(expect, str(got)); |
| } |
| |
| TEST_F(RobustnessTest, Matrix_Idx_OutOfBounds_Row) { |
| auto* src = R"( |
| var<private> a : mat3x2<f32>; |
| |
| fn f() { |
| var b : f32 = a[2][5]; |
| } |
| )"; |
| |
| auto* expect = R"( |
| var<private> a : mat3x2<f32>; |
| |
| fn f() { |
| var b : f32 = a[2][1]; |
| } |
| )"; |
| |
| auto got = Run<Robustness>(src); |
| |
| EXPECT_EQ(expect, str(got)); |
| } |
| |
| // TODO(dsinclair): Implement when constant_id exists |
| TEST_F(RobustnessTest, DISABLED_Vector_Constant_Id_Clamps) { |
| // [[override(1300)]] let idx : i32; |
| // var a : vec3<f32> |
| // var b : f32 = a[idx] |
| // |
| // ->var b : f32 = a[min(u32(idx), 2)] |
| } |
| |
| // TODO(dsinclair): Implement when constant_id exists |
| TEST_F(RobustnessTest, DISABLED_Array_Constant_Id_Clamps) { |
| // [[override(1300)]] let idx : i32; |
| // var a : array<f32, 4> |
| // var b : f32 = a[idx] |
| // |
| // -> var b : f32 = a[min(u32(idx), 3)] |
| } |
| |
| // TODO(dsinclair): Implement when constant_id exists |
| TEST_F(RobustnessTest, DISABLED_Matrix_Column_Constant_Id_Clamps) { |
| // [[override(1300)]] let idx : i32; |
| // var a : mat3x2<f32> |
| // var b : f32 = a[idx][1] |
| // |
| // -> var b : f32 = a[min(u32(idx), 2)][1] |
| } |
| |
| // TODO(dsinclair): Implement when constant_id exists |
| TEST_F(RobustnessTest, DISABLED_Matrix_Row_Constant_Id_Clamps) { |
| // [[override(1300)]] let idx : i32; |
| // var a : mat3x2<f32> |
| // var b : f32 = a[1][idx] |
| // |
| // -> var b : f32 = a[1][min(u32(idx), 0, 1)] |
| } |
| |
| TEST_F(RobustnessTest, RuntimeArray_Clamps) { |
| auto* src = R"( |
| [[block]] |
| struct S { |
| a : f32; |
| b : array<f32>; |
| }; |
| [[group(0), binding(0)]] var<storage, read> s : S; |
| |
| fn f() { |
| var d : f32 = s.b[25]; |
| } |
| )"; |
| |
| auto* expect = R"( |
| [[block]] |
| struct S { |
| a : f32; |
| b : array<f32>; |
| }; |
| |
| [[group(0), binding(0)]] var<storage, read> s : S; |
| |
| fn f() { |
| var d : f32 = s.b[min(u32(25), (arrayLength(&(s.b)) - 1u))]; |
| } |
| )"; |
| |
| auto got = Run<Robustness>(src); |
| |
| EXPECT_EQ(expect, str(got)); |
| } |
| |
| // TODO(dsinclair): Clamp atomics when available. |
| TEST_F(RobustnessTest, DISABLED_Atomics_Clamp) { |
| FAIL(); |
| } |
| |
| // Clamp textureLoad() coord values |
| TEST_F(RobustnessTest, TextureLoad_TextureCoord_Clamp) { |
| auto* src = R"( |
| [[group(0), binding(0)]] var tex1d : texture_1d<f32>; |
| |
| [[group(0), binding(1)]] var tex2d : texture_2d<f32>; |
| |
| [[group(0), binding(2)]] var tex3d : texture_3d<f32>; |
| |
| [[group(0), binding(3)]] var tex2d_arr : texture_storage_2d_array<rgba8sint, read>; |
| |
| fn f() { |
| ignore(textureLoad(tex1d, 10, 100)); |
| ignore(textureLoad(tex2d, vec2<i32>(10, 20), 100)); |
| ignore(textureLoad(tex3d, vec3<i32>(10, 20, 30), 100)); |
| ignore(textureLoad(tex2d_arr, vec2<i32>(10, 20), 100)); |
| } |
| )"; |
| |
| auto* expect = R"( |
| [[group(0), binding(0)]] var tex1d : texture_1d<f32>; |
| |
| [[group(0), binding(1)]] var tex2d : texture_2d<f32>; |
| |
| [[group(0), binding(2)]] var tex3d : texture_3d<f32>; |
| |
| [[group(0), binding(3)]] var tex2d_arr : texture_storage_2d_array<rgba8sint, read>; |
| |
| fn f() { |
| ignore(textureLoad(tex1d, clamp(10, i32(), textureDimensions(tex1d)), 100)); |
| ignore(textureLoad(tex2d, clamp(vec2<i32>(10, 20), vec2<i32>(), textureDimensions(tex2d)), 100)); |
| ignore(textureLoad(tex3d, clamp(vec3<i32>(10, 20, 30), vec3<i32>(), textureDimensions(tex3d)), 100)); |
| ignore(textureLoad(tex2d_arr, clamp(vec2<i32>(10, 20), vec2<i32>(), textureDimensions(tex2d_arr)), 100)); |
| } |
| )"; |
| |
| auto got = Run<Robustness>(src); |
| |
| EXPECT_EQ(expect, str(got)); |
| } |
| |
| // Clamp textureStore() coord values |
| TEST_F(RobustnessTest, TextureStore_TextureCoord_Clamp) { |
| auto* src = R"( |
| [[group(0), binding(0)]] var tex1d : texture_storage_1d<rgba8sint, write>; |
| |
| [[group(0), binding(1)]] var tex2d : texture_storage_2d<rgba8sint, write>; |
| |
| [[group(0), binding(2)]] var tex3d : texture_storage_3d<rgba8sint, write>; |
| |
| [[group(0), binding(3)]] var tex2d_arr : texture_storage_2d_array<rgba8sint, write>; |
| |
| fn f() { |
| textureStore(tex1d, 10, vec4<i32>()); |
| textureStore(tex2d, vec2<i32>(10, 20), vec4<i32>()); |
| textureStore(tex3d, vec3<i32>(10, 20, 30), vec4<i32>()); |
| textureStore(tex2d_arr, vec2<i32>(10, 20), 50, vec4<i32>()); |
| } |
| )"; |
| |
| auto* expect = R"( |
| [[group(0), binding(0)]] var tex1d : texture_storage_1d<rgba8sint, write>; |
| |
| [[group(0), binding(1)]] var tex2d : texture_storage_2d<rgba8sint, write>; |
| |
| [[group(0), binding(2)]] var tex3d : texture_storage_3d<rgba8sint, write>; |
| |
| [[group(0), binding(3)]] var tex2d_arr : texture_storage_2d_array<rgba8sint, write>; |
| |
| fn f() { |
| textureStore(tex1d, clamp(10, i32(), textureDimensions(tex1d)), vec4<i32>()); |
| textureStore(tex2d, clamp(vec2<i32>(10, 20), vec2<i32>(), textureDimensions(tex2d)), vec4<i32>()); |
| textureStore(tex3d, clamp(vec3<i32>(10, 20, 30), vec3<i32>(), textureDimensions(tex3d)), vec4<i32>()); |
| textureStore(tex2d_arr, clamp(vec2<i32>(10, 20), vec2<i32>(), textureDimensions(tex2d_arr)), 50, vec4<i32>()); |
| } |
| )"; |
| |
| auto got = Run<Robustness>(src); |
| |
| EXPECT_EQ(expect, str(got)); |
| } |
| |
| // TODO(dsinclair): Test for scoped variables when shadowing is implemented |
| TEST_F(RobustnessTest, DISABLED_Shadowed_Variable) { |
| // var a : array<f32, 3>; |
| // var i : u32; |
| // { |
| // var a : array<f32, 5>; |
| // var b : f32 = a[i]; |
| // } |
| // var c : f32 = a[i]; |
| // |
| // -> var b : f32 = a[min(u32(i), 4)]; |
| // var c : f32 = a[min(u32(i), 2)]; |
| FAIL(); |
| } |
| |
| // Check that existing use of min() and arrayLength() do not get renamed. |
| TEST_F(RobustnessTest, DontRenameSymbols) { |
| auto* src = R"( |
| [[block]] |
| struct S { |
| a : f32; |
| b : array<f32>; |
| }; |
| |
| [[group(0), binding(0)]] var<storage, read> s : S; |
| |
| let c : u32 = 1u; |
| |
| fn f() { |
| let b : f32 = s.b[c]; |
| let x : i32 = min(1, 2); |
| let y : u32 = arrayLength(&s.b); |
| } |
| )"; |
| |
| auto* expect = R"( |
| [[block]] |
| struct S { |
| a : f32; |
| b : array<f32>; |
| }; |
| |
| [[group(0), binding(0)]] var<storage, read> s : S; |
| |
| let c : u32 = 1u; |
| |
| fn f() { |
| let b : f32 = s.b[min(u32(c), (arrayLength(&(s.b)) - 1u))]; |
| let x : i32 = min(1, 2); |
| let y : u32 = arrayLength(&(s.b)); |
| } |
| )"; |
| |
| auto got = Run<Robustness>(src); |
| |
| EXPECT_EQ(expect, str(got)); |
| } |
| |
| } // namespace |
| } // namespace transform |
| } // namespace tint |