commit 51aed1c732133493fee3d855bfcd6906952068f4
author Ben Clayton <bclayton@google.com> Fri Nov 05 22:45:23 2021 +0000
committer Ben Clayton <bclayton@google.com> Fri Nov 05 22:45:23 2021 +0000
tree 33cf6afe934c972459b049b6fbf5b1409982ce10
parent 02acf59184c25eaa9c87a0f19c7356855b5ea3d4

main: Return non-zero status code on GLSL validation error

Change-Id: I55b49cec665947fb735037f762ae8692d990c24d
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/68521
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Stephen White <senorblanco@chromium.org>

samples/main.cc

diff --git a/samples/main.cc b/samples/main.cc
index 29835f4..5d55c01 100644
--- a/samples/main.cc
+++ b/samples/main.cc
@@ -868,6 +868,7 @@
 /// @returns true on success
 bool GenerateGlsl(const tint::Program* program, const Options& options) {
 #if TINT_BUILD_GLSL_WRITER
+  bool success = true;
   if (options.validate) {
     glslang::InitializeProcess();
   }
@@ -901,12 +902,12 @@
           std::cerr << "Error parsing GLSL shader:\n"
                     << shader.getInfoLog() << "\n"
                     << shader.getInfoDebugLog() << "\n";
+          success = false;
         }
       }
     }
   }
-
-  return true;
+  return success;
 #else
   (void)program;
   (void)options;