commit 5c34060a4e9216b10edd24a01b3ad6329a9bd25f
author Ben Clayton <bclayton@google.com> Tue Apr 13 23:46:17 2021 +0000
committer Commit Bot service account <commit-bot@chromium.org> Tue Apr 13 23:46:17 2021 +0000
tree 8e00a6389cf39e5bc4e494d79708491c9acbe9e8
parent 4d349b5391c04eea7e783d602846c6338fb31bfe

transform/hlsl: Use Symbols().New() for empty entry point

And drop the leading understore, it's no longer needed.

Bug tint:712

Change-Id: Ic0ad304119ceb148984d2fa0a5e9e61f2c3a89fd
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/47637
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>

src/transform/hlsl.cc

diff --git a/src/transform/hlsl.cc b/src/transform/hlsl.cc
index 0da3013..5972a82 100644
--- a/src/transform/hlsl.cc
+++ b/src/transform/hlsl.cc
@@ -698,7 +698,8 @@
     }
   }
   ctx.dst->Func(
-      "_tint_unused_entry_point", {}, ctx.dst->ty.void_(), {},
+      ctx.dst->Symbols().New("tint_unused_entry_point"), {},
+      ctx.dst->ty.void_(), {},
       {ctx.dst->create<ast::StageDecoration>(ast::PipelineStage::kVertex)});
 }
 

src/transform/hlsl_test.cc

diff --git a/src/transform/hlsl_test.cc b/src/transform/hlsl_test.cc
index 471ece1..1f1515b 100644
--- a/src/transform/hlsl_test.cc
+++ b/src/transform/hlsl_test.cc
@@ -284,7 +284,7 @@
 
   auto* expect = R"(
 [[stage(vertex)]]
-fn _tint_unused_entry_point() {
+fn tint_unused_entry_point() {
 }
 )";