commit 648b05e4e2868b57163648548a653d3eece01fbf
author Ben Clayton <bclayton@google.com> Fri Apr 16 10:37:34 2021 +0000
committer Commit Bot service account <commit-bot@chromium.org> Fri Apr 16 10:37:34 2021 +0000
tree ad935e6ecba5e9427fb967d52b87477d4cf0ba48
parent 8cb5a23afba97e0ea4dec6e96ae25ac9f1954855

Fix AttemptTintPadSymbolCollision test

This test landed simultaneously with a change that checks that storage buffers have an access qualifier, leading to broken tests.

Also fix lint issues that have crept in.

Change-Id: I4a7f0bc67d8d3e7170ddea117342a510741a495c
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/48040
Auto-Submit: Ben Clayton <bclayton@google.com>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

src/resolver/decoration_validation_test.cc

diff --git a/src/resolver/decoration_validation_test.cc b/src/resolver/decoration_validation_test.cc
index 0c021a2..6b74e1e 100644
--- a/src/resolver/decoration_validation_test.cc
+++ b/src/resolver/decoration_validation_test.cc
@@ -418,9 +418,7 @@
         Params{ty_vec4<f32>, (default_vec4.align - 1) * 7, false},
         Params{ty_mat2x2<f32>, (default_mat2x2.align - 1) * 7, false},
         Params{ty_mat3x3<f32>, (default_mat3x3.align - 1) * 7, false},
-        Params{ty_mat4x4<f32>, (default_mat4x4.align - 1) * 7, false}
-
-        ));
+        Params{ty_mat4x4<f32>, (default_mat4x4.align - 1) * 7, false}));
 
 }  // namespace
 }  // namespace ArrayStrideTests

src/transform/hlsl_test.cc

diff --git a/src/transform/hlsl_test.cc b/src/transform/hlsl_test.cc
index 1f97e46..e0273c2 100644
--- a/src/transform/hlsl_test.cc
+++ b/src/transform/hlsl_test.cc
@@ -289,8 +289,8 @@
   auto got = Run<Hlsl>(src);
 
   EXPECT_EQ(expect, str(got));
-
 }
+
 }  // namespace
 }  // namespace transform
 }  // namespace tint

src/writer/msl/generator_impl_type_test.cc

diff --git a/src/writer/msl/generator_impl_type_test.cc b/src/writer/msl/generator_impl_type_test.cc
index 9af4778..69d36c9 100644
--- a/src/writer/msl/generator_impl_type_test.cc
+++ b/src/writer/msl/generator_impl_type_test.cc
@@ -525,7 +525,8 @@
           Member("tint_pad_21", ty.f32()),
       });
 
-  Global("G", s, ast::StorageClass::kStorage);
+  Global("G", ty.access(ast::AccessControl::kReadOnly, s),
+         ast::StorageClass::kStorage);
 
   GeneratorImpl& gen = Build();