commit | 9943de6813695e831a9e6aa43ae36322e81ae3e6 | [log] [tgz] |
---|---|---|

author | Antonio Maiorano <amaiorano@google.com> | Wed Dec 22 15:02:09 2021 +0000 |

committer | Tint LUCI CQ <tint-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Dec 22 15:02:09 2021 +0000 |

tree | d880fb1a65dace3488f43262b7da4394d3d249f3 | |

parent | cc4d97b6e31962c0d5645e8ed7a4bdfbfc4d7339 [diff] |

Fix FXC compile errors on modulo by zero Just like for divide, FXC fails with the exact same error when performing a modulo on a value that FXC determines to be zero. We address it in the same way as we do for divide. This also fixes a couple of the vk-gl-cts tests for which I manually generated expectation files for. Bug: tint:1083 Change-Id: Ia388bf002112afded542adb791d37e88e35a77ff Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/74220 Reviewed-by: James Price <jrprice@google.com> Kokoro: Kokoro <noreply+kokoro@google.com> Commit-Queue: Antonio Maiorano <amaiorano@google.com>

- src/program_builder.h[diff]
- src/writer/hlsl/generator_impl.cc[diff]
- src/writer/hlsl/generator_impl_binary_test.cc[diff]
- test/bug/chromium/1273230.wgsl.expected.hlsl[diff]
- test/bug/tint/1113.wgsl.expected.hlsl[diff]
- test/expressions/binary/mod_by_zero/by_constant/scalar-scalar/f32.wgsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_constant/scalar-scalar/f32.wgsl.expected.hlsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_constant/scalar-scalar/f32.wgsl.expected.msl[Added - diff]
- test/expressions/binary/mod_by_zero/by_constant/scalar-scalar/f32.wgsl.expected.spvasm[Added - diff]
- test/expressions/binary/mod_by_zero/by_constant/scalar-scalar/f32.wgsl.expected.wgsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_constant/scalar-scalar/i32.wgsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_constant/scalar-scalar/i32.wgsl.expected.hlsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_constant/scalar-scalar/i32.wgsl.expected.msl[Added - diff]
- test/expressions/binary/mod_by_zero/by_constant/scalar-scalar/i32.wgsl.expected.spvasm[Added - diff]
- test/expressions/binary/mod_by_zero/by_constant/scalar-scalar/i32.wgsl.expected.wgsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_constant/scalar-scalar/u32.wgsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_constant/scalar-scalar/u32.wgsl.expected.hlsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_constant/scalar-scalar/u32.wgsl.expected.msl[Added - diff]
- test/expressions/binary/mod_by_zero/by_constant/scalar-scalar/u32.wgsl.expected.spvasm[Added - diff]
- test/expressions/binary/mod_by_zero/by_constant/scalar-scalar/u32.wgsl.expected.wgsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_constant/scalar-vec3/i32.wgsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_constant/scalar-vec3/i32.wgsl.expected.hlsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_constant/scalar-vec3/i32.wgsl.expected.msl[Added - diff]
- test/expressions/binary/mod_by_zero/by_constant/scalar-vec3/i32.wgsl.expected.spvasm[Added - diff]
- test/expressions/binary/mod_by_zero/by_constant/scalar-vec3/i32.wgsl.expected.wgsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_constant/scalar-vec3/u32.wgsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_constant/scalar-vec3/u32.wgsl.expected.hlsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_constant/scalar-vec3/u32.wgsl.expected.msl[Added - diff]
- test/expressions/binary/mod_by_zero/by_constant/scalar-vec3/u32.wgsl.expected.spvasm[Added - diff]
- test/expressions/binary/mod_by_zero/by_constant/scalar-vec3/u32.wgsl.expected.wgsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_constant/vec3-scalar/i32.wgsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_constant/vec3-scalar/i32.wgsl.expected.hlsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_constant/vec3-scalar/i32.wgsl.expected.msl[Added - diff]
- test/expressions/binary/mod_by_zero/by_constant/vec3-scalar/i32.wgsl.expected.spvasm[Added - diff]
- test/expressions/binary/mod_by_zero/by_constant/vec3-scalar/i32.wgsl.expected.wgsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_constant/vec3-scalar/u32.wgsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_constant/vec3-scalar/u32.wgsl.expected.hlsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_constant/vec3-scalar/u32.wgsl.expected.msl[Added - diff]
- test/expressions/binary/mod_by_zero/by_constant/vec3-scalar/u32.wgsl.expected.spvasm[Added - diff]
- test/expressions/binary/mod_by_zero/by_constant/vec3-scalar/u32.wgsl.expected.wgsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_constant/vec3-vec3/f32.wgsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_constant/vec3-vec3/f32.wgsl.expected.hlsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_constant/vec3-vec3/f32.wgsl.expected.msl[Added - diff]
- test/expressions/binary/mod_by_zero/by_constant/vec3-vec3/f32.wgsl.expected.spvasm[Added - diff]
- test/expressions/binary/mod_by_zero/by_constant/vec3-vec3/f32.wgsl.expected.wgsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_constant/vec3-vec3/i32.wgsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_constant/vec3-vec3/i32.wgsl.expected.hlsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_constant/vec3-vec3/i32.wgsl.expected.msl[Added - diff]
- test/expressions/binary/mod_by_zero/by_constant/vec3-vec3/i32.wgsl.expected.spvasm[Added - diff]
- test/expressions/binary/mod_by_zero/by_constant/vec3-vec3/i32.wgsl.expected.wgsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_constant/vec3-vec3/u32.wgsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_constant/vec3-vec3/u32.wgsl.expected.hlsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_constant/vec3-vec3/u32.wgsl.expected.msl[Added - diff]
- test/expressions/binary/mod_by_zero/by_constant/vec3-vec3/u32.wgsl.expected.spvasm[Added - diff]
- test/expressions/binary/mod_by_zero/by_constant/vec3-vec3/u32.wgsl.expected.wgsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_expression/scalar-scalar/f32.wgsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_expression/scalar-scalar/f32.wgsl.expected.hlsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_expression/scalar-scalar/f32.wgsl.expected.msl[Added - diff]
- test/expressions/binary/mod_by_zero/by_expression/scalar-scalar/f32.wgsl.expected.spvasm[Added - diff]
- test/expressions/binary/mod_by_zero/by_expression/scalar-scalar/f32.wgsl.expected.wgsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_expression/scalar-scalar/i32.wgsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_expression/scalar-scalar/i32.wgsl.expected.hlsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_expression/scalar-scalar/i32.wgsl.expected.msl[Added - diff]
- test/expressions/binary/mod_by_zero/by_expression/scalar-scalar/i32.wgsl.expected.spvasm[Added - diff]
- test/expressions/binary/mod_by_zero/by_expression/scalar-scalar/i32.wgsl.expected.wgsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_expression/scalar-scalar/u32.wgsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_expression/scalar-scalar/u32.wgsl.expected.hlsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_expression/scalar-scalar/u32.wgsl.expected.msl[Added - diff]
- test/expressions/binary/mod_by_zero/by_expression/scalar-scalar/u32.wgsl.expected.spvasm[Added - diff]
- test/expressions/binary/mod_by_zero/by_expression/scalar-scalar/u32.wgsl.expected.wgsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_expression/scalar-vec3/i32.wgsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_expression/scalar-vec3/i32.wgsl.expected.hlsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_expression/scalar-vec3/i32.wgsl.expected.msl[Added - diff]
- test/expressions/binary/mod_by_zero/by_expression/scalar-vec3/i32.wgsl.expected.spvasm[Added - diff]
- test/expressions/binary/mod_by_zero/by_expression/scalar-vec3/i32.wgsl.expected.wgsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_expression/scalar-vec3/u32.wgsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_expression/scalar-vec3/u32.wgsl.expected.hlsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_expression/scalar-vec3/u32.wgsl.expected.msl[Added - diff]
- test/expressions/binary/mod_by_zero/by_expression/scalar-vec3/u32.wgsl.expected.spvasm[Added - diff]
- test/expressions/binary/mod_by_zero/by_expression/scalar-vec3/u32.wgsl.expected.wgsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_expression/vec3-scalar/i32.wgsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_expression/vec3-scalar/i32.wgsl.expected.hlsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_expression/vec3-scalar/i32.wgsl.expected.msl[Added - diff]
- test/expressions/binary/mod_by_zero/by_expression/vec3-scalar/i32.wgsl.expected.spvasm[Added - diff]
- test/expressions/binary/mod_by_zero/by_expression/vec3-scalar/i32.wgsl.expected.wgsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_expression/vec3-scalar/u32.wgsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_expression/vec3-scalar/u32.wgsl.expected.hlsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_expression/vec3-scalar/u32.wgsl.expected.msl[Added - diff]
- test/expressions/binary/mod_by_zero/by_expression/vec3-scalar/u32.wgsl.expected.spvasm[Added - diff]
- test/expressions/binary/mod_by_zero/by_expression/vec3-scalar/u32.wgsl.expected.wgsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_expression/vec3-vec3/f32.wgsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_expression/vec3-vec3/f32.wgsl.expected.hlsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_expression/vec3-vec3/f32.wgsl.expected.msl[Added - diff]
- test/expressions/binary/mod_by_zero/by_expression/vec3-vec3/f32.wgsl.expected.spvasm[Added - diff]
- test/expressions/binary/mod_by_zero/by_expression/vec3-vec3/f32.wgsl.expected.wgsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_expression/vec3-vec3/i32.wgsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_expression/vec3-vec3/i32.wgsl.expected.hlsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_expression/vec3-vec3/i32.wgsl.expected.msl[Added - diff]
- test/expressions/binary/mod_by_zero/by_expression/vec3-vec3/i32.wgsl.expected.spvasm[Added - diff]
- test/expressions/binary/mod_by_zero/by_expression/vec3-vec3/i32.wgsl.expected.wgsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_expression/vec3-vec3/u32.wgsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_expression/vec3-vec3/u32.wgsl.expected.hlsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_expression/vec3-vec3/u32.wgsl.expected.msl[Added - diff]
- test/expressions/binary/mod_by_zero/by_expression/vec3-vec3/u32.wgsl.expected.spvasm[Added - diff]
- test/expressions/binary/mod_by_zero/by_expression/vec3-vec3/u32.wgsl.expected.wgsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_identifier/scalar-scalar/f32.wgsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_identifier/scalar-scalar/f32.wgsl.expected.hlsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_identifier/scalar-scalar/f32.wgsl.expected.msl[Added - diff]
- test/expressions/binary/mod_by_zero/by_identifier/scalar-scalar/f32.wgsl.expected.spvasm[Added - diff]
- test/expressions/binary/mod_by_zero/by_identifier/scalar-scalar/f32.wgsl.expected.wgsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_identifier/scalar-scalar/i32.wgsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_identifier/scalar-scalar/i32.wgsl.expected.hlsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_identifier/scalar-scalar/i32.wgsl.expected.msl[Added - diff]
- test/expressions/binary/mod_by_zero/by_identifier/scalar-scalar/i32.wgsl.expected.spvasm[Added - diff]
- test/expressions/binary/mod_by_zero/by_identifier/scalar-scalar/i32.wgsl.expected.wgsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_identifier/scalar-scalar/u32.wgsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_identifier/scalar-scalar/u32.wgsl.expected.hlsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_identifier/scalar-scalar/u32.wgsl.expected.msl[Added - diff]
- test/expressions/binary/mod_by_zero/by_identifier/scalar-scalar/u32.wgsl.expected.spvasm[Added - diff]
- test/expressions/binary/mod_by_zero/by_identifier/scalar-scalar/u32.wgsl.expected.wgsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_identifier/scalar-vec3/i32.wgsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_identifier/scalar-vec3/i32.wgsl.expected.hlsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_identifier/scalar-vec3/i32.wgsl.expected.msl[Added - diff]
- test/expressions/binary/mod_by_zero/by_identifier/scalar-vec3/i32.wgsl.expected.spvasm[Added - diff]
- test/expressions/binary/mod_by_zero/by_identifier/scalar-vec3/i32.wgsl.expected.wgsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_identifier/scalar-vec3/u32.wgsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_identifier/scalar-vec3/u32.wgsl.expected.hlsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_identifier/scalar-vec3/u32.wgsl.expected.msl[Added - diff]
- test/expressions/binary/mod_by_zero/by_identifier/scalar-vec3/u32.wgsl.expected.spvasm[Added - diff]
- test/expressions/binary/mod_by_zero/by_identifier/scalar-vec3/u32.wgsl.expected.wgsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_identifier/vec3-scalar/i32.wgsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_identifier/vec3-scalar/i32.wgsl.expected.hlsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_identifier/vec3-scalar/i32.wgsl.expected.msl[Added - diff]
- test/expressions/binary/mod_by_zero/by_identifier/vec3-scalar/i32.wgsl.expected.spvasm[Added - diff]
- test/expressions/binary/mod_by_zero/by_identifier/vec3-scalar/i32.wgsl.expected.wgsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_identifier/vec3-scalar/u32.wgsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_identifier/vec3-scalar/u32.wgsl.expected.hlsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_identifier/vec3-scalar/u32.wgsl.expected.msl[Added - diff]
- test/expressions/binary/mod_by_zero/by_identifier/vec3-scalar/u32.wgsl.expected.spvasm[Added - diff]
- test/expressions/binary/mod_by_zero/by_identifier/vec3-scalar/u32.wgsl.expected.wgsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_identifier/vec3-vec3/f32.wgsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_identifier/vec3-vec3/f32.wgsl.expected.hlsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_identifier/vec3-vec3/f32.wgsl.expected.msl[Added - diff]
- test/expressions/binary/mod_by_zero/by_identifier/vec3-vec3/f32.wgsl.expected.spvasm[Added - diff]
- test/expressions/binary/mod_by_zero/by_identifier/vec3-vec3/f32.wgsl.expected.wgsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_identifier/vec3-vec3/i32.wgsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_identifier/vec3-vec3/i32.wgsl.expected.hlsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_identifier/vec3-vec3/i32.wgsl.expected.msl[Added - diff]
- test/expressions/binary/mod_by_zero/by_identifier/vec3-vec3/i32.wgsl.expected.spvasm[Added - diff]
- test/expressions/binary/mod_by_zero/by_identifier/vec3-vec3/i32.wgsl.expected.wgsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_identifier/vec3-vec3/u32.wgsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_identifier/vec3-vec3/u32.wgsl.expected.hlsl[Added - diff]
- test/expressions/binary/mod_by_zero/by_identifier/vec3-vec3/u32.wgsl.expected.msl[Added - diff]
- test/expressions/binary/mod_by_zero/by_identifier/vec3-vec3/u32.wgsl.expected.spvasm[Added - diff]
- test/expressions/binary/mod_by_zero/by_identifier/vec3-vec3/u32.wgsl.expected.wgsl[Added - diff]
- test/vk-gl-cts/graphicsfuzz/cov-loop-increment-or-divide-by-loop-index/0-opt.spvasm.expected.hlsl[diff]
- test/vk-gl-cts/graphicsfuzz/cov-loop-increment-or-divide-by-loop-index/0-opt.wgsl.expected.hlsl[diff]
- test/vk-gl-cts/graphicsfuzz/cov-modulo-zero-never-executed/0-opt.spvasm.expected.hlsl[diff]
- test/vk-gl-cts/graphicsfuzz/cov-modulo-zero-never-executed/0-opt.wgsl.expected.hlsl[diff]

159 files changed

tree: d880fb1a65dace3488f43262b7da4394d3d249f3

- .vscode/
- build_overrides/
- docs/
- fuzzers/
- include/
- infra/
- kokoro/
- samples/
- src/
- test/
- third_party/
- tools/
- .clang-format
- .gitignore
- .gn
- AUTHORS
- BUILD.gn
- CMakeLists.txt
- CMakeSettings.json
- CODE_OF_CONDUCT.md
- CONTRIBUTING.md
- CPPLINT.cfg
- DEPS
- Doxyfile
- LICENSE
- OWNERS
- PRESUBMIT.py
- README.md
- standalone.gclient
- tint_overrides_with_defaults.gni

README.md

Tint is a compiler for the WebGPU Shader Language (WGSL).

This is not an officially supported Google product.

- Git
- CMake (3.10.2 or later)
- Ninja (or other build tool)
- Python, for fetching dependencies
- depot_tools in your path

`TINT_BUILD_SPV_READER`

: enable the SPIR-V input reader (off by default)`TINT_BUILD_WGSL_READER`

: enable the WGSL input reader (on by default)`TINT_BUILD_SPV_WRITER`

: enable the SPIR-V output writer (on by default)`TINT_BUILD_WGSL_WRITER`

: enable the WGSL output writer (on by default)`TINT_BUILD_FUZZERS`

: enable building fuzzzers (off by default)

Tint uses Chromium dependency management so you need to install depot_tools and add it to your PATH.

# Clone the repo as "tint" git clone https://dawn.googlesource.com/tint tint cd tint # Bootstrap the gclient configuration cp standalone.gclient .gclient # Fetch external dependencies and toolchains with gclient gclient sync

mkdir -p out/Debug cd out/Debug cmake -GNinja ../.. ninja # or autoninja

mkdir -p out/Debug cd out/Debug cmake ../.. make # -j N for N-way parallel build

mkdir -p out/Debug gn gen out/Debug autoninja -C out/Debug

If you are attempting fuzz, using `TINT_BUILD_FUZZERS=ON`

, the version of llvm in the XCode SDK does not have the needed libfuzzer functionality included.

The build error that you will see from using the XCode SDK will look something like this:

ld: file not found:/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/11.0.0/lib/darwin/libclang_rt.fuzzer_osx.a

The solution to this problem is to use a full version llvm, like what you would get via homebrew, `brew install llvm`

, and use something like `CC=<path to full clang> cmake ..`

to setup a build using that toolchain.

The gn based work flow uses the Chromium toolchain for building in anticipation of integration of Tint into Chromium based projects. This toolchain has additional plugins for checking for style issues, which are marked with [chromium-style] in log messages. This means that this toolchain is more strict then the default clang toolchain.

In the future we will have a CQ that will build this work flow and flag issues automatically. Until that is in place, to avoid causing breakages you can run the [chromium-style] checks using the CMake based work flows. This requires setting `CC`

to the version of clang checked out by `gclient sync`

and setting the `TINT_CHECK_CHROMIUM_STYLE`

to `ON`

.

mkdir -p out/style cd out/style cmake ../.. CC=../../third_party/llvm-build/Release+Asserts/bin/clang cmake -DTINT_CHECK_CHROMIUM_STYLE=ON ../../ # add -GNinja for ninja builds

Please file any issues or feature requests at https://bugs.chromium.org/p/tint/issues/entry

Please see the CONTRIBUTING and CODE_OF_CONDUCT files on how to contribute to Tint.

Tint has a process for supporting experimental extensions.