commit c8ffbe43a7b35eb5696afc1691249a5627fd3a4b
author James Price <jrprice@google.com> Fri Apr 09 20:14:18 2021 +0000
committer Commit Bot service account <commit-bot@chromium.org> Fri Apr 09 20:14:18 2021 +0000
tree ff0a4d42993348a51ebfc21c47da0e1637c96e98
parent 3ee8c37cb6bf97775afe67e81a0b200e4661f0ec

Output all diagnostics from tint executable

Otherwise warnings are not emitted unless there is also an error.

Change-Id: If417f75fbdd246b1f792a0f63b83274c8f2272e3
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/47481
Auto-Submit: James Price <jrprice@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: James Price <jrprice@google.com>

samples/main.cc

diff --git a/samples/main.cc b/samples/main.cc
index 2f9f7b8..17acb9a 100644
--- a/samples/main.cc
+++ b/samples/main.cc
@@ -659,8 +659,10 @@
               << options.input_filename << std::endl;
     return 1;
   }
-  if (!program->IsValid()) {
+  if (program->Diagnostics().count() > 0) {
     diag_formatter.format(program->Diagnostics(), diag_printer.get());
+  }
+  if (!program->IsValid()) {
     return 1;
   }