Adding a TODO for updating textureLoad on storage images
Change-Id: I1d724a1743caa94ba040aca804dfac6abbb2d6e5
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/28360
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Tomek Ponitka <tommek@google.com>
diff --git a/src/type_determiner.cc b/src/type_determiner.cc
index e94f9d6..79ec8dc 100644
--- a/src/type_determiner.cc
+++ b/src/type_determiner.cc
@@ -588,6 +588,8 @@
return true;
}
if (ast::intrinsic::IsTextureOperationIntrinsic(name)) {
+ // TODO: Remove the LOD param from textureLoad on storage textures when
+ // https://github.com/gpuweb/gpuweb/pull/1032 gets merged.
uint32_t num_of_params =
(name == "textureLoad" || name == "textureSample") ? 3 : 4;
if (expr->params().size() != num_of_params) {
diff --git a/src/writer/spirv/builder.cc b/src/writer/spirv/builder.cc
index 7bbfa02..bce9333 100644
--- a/src/writer/spirv/builder.cc
+++ b/src/writer/spirv/builder.cc
@@ -1529,6 +1529,8 @@
->UnwrapAliasPtrAlias()
->AsTexture();
+ // TODO: Remove the LOD param from textureLoad on storage textures when
+ // https://github.com/gpuweb/gpuweb/pull/1032 gets merged.
if (name == "textureLoad") {
auto spirv_params = {std::move(wgsl_params[0]),
std::move(wgsl_params[1]),
