commit 025880595d06fe5ab41022555b03983ba2aae9b1
author Sunny Sachanandani <sunnyps@chromium.org> Tue Oct 04 00:08:52 2022 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Oct 04 00:08:52 2022 +0000
tree 2ca76e25579d3be0cb2d3ca28b18a613cf69013a
parent 4ff00cc4709877b30eee1f74e7180b3de707a7e7

d3d12: Keep wait fences alive until GPU completion

In D3D12, objects need to be kept alive until they're done being used on
the GPU. This is particularly important for wait fences imported into
Dawn otherwise the waits don't happen sometimes.

Bug: dawn:576
Change-Id: Id2d8af59f1530a1e507471cf2e4653ac5cfbae06
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/104425
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>

src/dawn/native/d3d12/TextureD3D12.cpp

diff --git a/src/dawn/native/d3d12/TextureD3D12.cpp b/src/dawn/native/d3d12/TextureD3D12.cpp
index d7fc90f..a754821 100644
--- a/src/dawn/native/d3d12/TextureD3D12.cpp
+++ b/src/dawn/native/d3d12/TextureD3D12.cpp
@@ -739,6 +739,8 @@
         DAWN_TRY(CheckHRESULT(device->GetCommandQueue()->Wait(fence->GetD3D12Fence(),
                                                               fence->GetFenceValue()),
                               "D3D12 fence wait"););
+        // Keep D3D12 fence alive since we'll clear the waitFences list below.
+        device->ReferenceUntilUnused(fence->GetD3D12Fence());
     }
     mWaitFences.clear();
     return {};