commit 042335fbac0582eb57a93c8bf04fa0383ad5e58a
author Corentin Wallez <cwallez@chromium.org> Tue Apr 06 17:32:19 2021 +0000
committer Commit Bot service account <commit-bot@chromium.org> Tue Apr 06 17:32:19 2021 +0000
tree ccf581e864d1e9cb103932052d5eea7cc9c8bee6
parent 9e252c0536a2033c560fb2f47b250219efbde06b

Add the -Wredundant-move warning.

Dawn uses objects with move semantics like Ref<> that feel like they
need to be std::moved in a bunch of places. This warning triggers when
std::move() is used when it has no effect, keep the code less verbose.

Bug: None
Change-Id: I2b11f709e943e7b16024bfde07910577b983aa34
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/46441
Commit-Queue: Stephen White <senorblanco@chromium.org>
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Stephen White <senorblanco@chromium.org>

src/common/BUILD.gn

diff --git a/src/common/BUILD.gn b/src/common/BUILD.gn
index fdca30b..176e82e 100644
--- a/src/common/BUILD.gn
+++ b/src/common/BUILD.gn
@@ -106,6 +106,7 @@
       "-Wnon-c-typedef-for-linkage",
       "-Wpessimizing-move",
       "-Wrange-loop-analysis",
+      "-Wredundant-move",
       "-Wshadow-field",
       "-Wstrict-prototypes",
       "-Wtautological-unsigned-zero-compare",