| commit | 04e38e884b952543601bb05c85eb175f20eb0b8c | [log] [tgz] |
|---|---|---|
| author | Ben Clayton <bclayton@google.com> | Wed May 29 20:57:56 2024 +0000 |
| committer | Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed May 29 20:57:56 2024 +0000 |
| tree | d625a15b3de8b9beadd86c218f6bcd0424686892 | |
| parent | dd89ce45f54704e4cdd147f295ba872b8af50a43 [diff] |
[tint][resolver] Mark all short-circuited RHS expressions as not-evaluated Not just those that would otherwise be const-expression. The rules around this were patchy, and there were situations where if the RHS was a runtime-expression builtin call, the binary op would be classed as EvaluationStage::kRuntime, the LHS expression EvaluationStage::kConstant, and the RHS classed as EvaluationStage::kRuntime, but the RHS sub-expressions were marked EvaluationStage::kNotEvaluated. This would lead to bad assumptions downstream. With this change, a short-circuited binary expression with a const-expression LHS will always become EvaluationStage::kConstant, with the LHS being EvaluationStage::kConstant and the RHS always being EvaluationStage::kNotEvaluated. Fixed: 341124493 Change-Id: I47d4b7e3ce1a74f74db4a51e816f114aa3bec015 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/190400 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: James Price <jrprice@google.com>
Dawn is an open-source and cross-platform implementation of the WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.
Dawn provides several WebGPU building blocks:
webgpu.h version that Dawn implements.webgpu.h.Helpful links:
Developer documentation:
User documentation: (TODO, figure out what overlaps with the webgpu.h docs)
BSD 3-Clause License, please see LICENSE.
This is not an officially supported Google product.