Google Git
Sign in
dawn / dawn / 0b1bba3f287e6228c13b90eaebba9e57f7d6f883
commit0b1bba3f287e6228c13b90eaebba9e57f7d6f883[log] [tgz]
authorLokbondo Kung <lokokung@google.com>Thu Aug 29 17:44:56 2024 +0000
committerDawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Aug 29 17:44:56 2024 +0000
tree01bc28611ef88f32da2b7aa8e6455b81c45117d1
parente81af3d568b08249e97092023de256c257cbc862 [diff]
[dawn][native] Make sure to hold Device lock before handling errors.

- Briefly, the bug we saw was a result of errors being generated in
  the Device during a ProcessEvent call which was not taking the
  appropriate Device lock. With the minimal change in PS1 by
  acquiring the lock, it exposed an existing issue where we could
  have lock acquiring inversion between the mEvents lock in the
  EventManager and the device lock. To fix this, we needed to
  release the mEvents lock in ProcessEvents before calling into
  the code that needs the device lock. Once that was fixed, we
  the tests were failing because ProcessEvents is no longer a fully
  "atomic" operation and the WaitRefs asserts were being triggered.
  To fix that, we removed the WaitRef entirely since it was more
  restrictive than the desired behavior.

Bug: 354748063
Change-Id: I586b3acdb8801ddd9d4b2b57da7824e37e23e595
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/204154
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Loko Kung <lokokung@google.com>
1 file changed
tree: 01bc28611ef88f32da2b7aa8e6455b81c45117d1
  1. .github/
  2. .vscode/
  3. build_overrides/
  4. docs/
  5. generator/
  6. include/
  7. infra/
  8. scripts/
  9. src/
  10. test/
  11. third_party/
  12. tools/
  13. webgpu-cts/
  14. build
  15. buildtools
  16. testing
  17. .bazelrc
  18. .clang-format
  19. .clang-tidy
  20. .gitattributes
  21. .gitignore
  22. .gitmodules
  23. .gn
  24. AUTHORS
  25. BUILD.bazel
  26. BUILD.gn
  27. CMakeLists.txt
  28. CMakeSettings.json
  29. CODE_OF_CONDUCT.md
  30. codereview.settings
  31. CONTRIBUTING.md
  32. CPPLINT.cfg
  33. DEPS
  34. DIR_METADATA
  35. go.mod
  36. go.sum
  37. go_presubmit_support.py
  38. LICENSE
  39. OWNERS
  40. PRESUBMIT.py
  41. README.chromium
  42. README.md
  43. WORKSPACE.bazel
README.md

Build Status Matrix Space

Dawn, a WebGPU implementation

Dawn is an open-source and cross-platform implementation of the WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.

Dawn provides several WebGPU building blocks:

  • WebGPU C/C++ headers that applications and other building blocks use.
    • The webgpu.h version that Dawn implements.
    • A C++ wrapper for the webgpu.h.
  • A “native” implementation of WebGPU using platforms' GPU APIs: D3D12, Metal, Vulkan and OpenGL. See per API support for more details.
  • A client-server implementation of WebGPU for applications that are in a sandbox without access to native drivers
  • Tint is a compiler for the WebGPU Shader Language (WGSL) that can be used in standalone to convert shaders from and to WGSL.

Helpful links:

Documentation table of content

Developer documentation:

User documentation: (TODO, figure out what overlaps with the webgpu.h docs)

License

BSD 3-Clause License, please see LICENSE.

Disclaimer

This is not an officially supported Google product.