Google Git
Sign in
dawn/dawn/0bc97cb2f50a092b4f332c8cb2b3285de7ccc39d
commit
0bc97cb2f50a092b4f332c8cb2b3285de7ccc39d
[log]
author
Stephen White <senorblanco@chromium.org>
Thu May 21 10:10:38 2026 -0700
committer
dawn-scoped@luci-project-accounts.iam.gserviceaccount.com <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com>
Thu May 21 10:10:38 2026 -0700
tree
4c95e4522d9d32c591b46a207f55de5487efd95c
parent
d4275b9a57cccdbc9e87da455b8d75526902f324 [diff]
GL: fix issue with ShaderStage::None bindings.

If more than 96 bindings with visibility ShaderStage::None are used,
they will exceed kGLMaxShaderStorageBufferBindingsReported (aka
GL_MAX_SHADER_STORAGE_BUFFER_BINDINGS) in the GL backend.
Dawn validation will not catch this, since it skips such bindings.
The fix is to skip all of the bindings with visibility ShaderStage::None
when computing binding indices in pipeline layout construction and
when applying bind groups in the GL backend.

Bug: 511727159
Change-Id: Ibc873a5afab4e73c12ad25b7d7cedcf48f35ca6e
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/309876
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Stephen White <senorblanco@chromium.org>
3 files changed
tree: 4c95e4522d9d32c591b46a207f55de5487efd95c
  1. .github/
  2. .vscode/
  3. agents/
  4. build_overrides/
  5. docs/
  6. generator/
  7. include/
  8. infra/
  9. scripts/
  10. src/
  11. test/
  12. third_party/
  13. tools/
  14. webgpu-cts/
  15. build
  16. buildtools
  17. testing
  18. .bazelrc
  19. .clang-format
  20. .clang-format-ignore
  21. .clang-tidy
  22. .git-blame-ignore-revs
  23. .gitattributes
  24. .gitignore
  25. .gitmodules
  26. .gn
  27. .style.yapf
  28. .vpython3
  29. AUTHORS
  30. BUILD.bazel
  31. BUILD.gn
  32. CMakeLists.txt
  33. CMakeSettings.json
  34. CODE_OF_CONDUCT.md
  35. codereview.settings
  36. CONTRIBUTING.md
  37. CPPLINT.cfg
  38. DEPS
  39. DIR_METADATA
  40. go.mod
  41. go.sum
  42. go_presubmit_support.py
  43. LICENSE
  44. OWNERS
  45. PRESUBMIT.py
  46. README.chromium
  47. README.md
  48. unsafe_buffers_paths.txt
  49. WATCHLISTS
  50. WORKSPACE.bazel
README.md

Build Status Matrix Space

Dawn, a WebGPU implementation

Dawn is an open-source and cross-platform implementation of the WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.

Dawn provides several WebGPU building blocks:

  • WebGPU C/C++ headers that applications and other building blocks use.
    • The webgpu.h version that Dawn implements.
    • A C++ wrapper for the webgpu.h.
  • A “native” implementation of WebGPU using platforms' GPU APIs: D3D12, Metal, Vulkan and OpenGL. See per API support for more details.
  • A client-server implementation of WebGPU for applications that are in a sandbox without access to native drivers
  • Tint is a compiler for the WebGPU Shader Language (WGSL) that can be used in standalone to convert shaders from and to WGSL.

Helpful links:

Documentation table of content

Developer documentation:

User documentation: (TODO, figure out what overlaps with the webgpu.h docs)

License

BSD 3-Clause License, please see LICENSE.

Disclaimer

This is not an officially supported Google product.