commit 0d2c6c62157f2d5c689ad5aba8db7ee02acdf5de
author Corentin Wallez <cwallez@chromium.org> Mon Jan 10 14:30:14 2022 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Jan 10 14:30:14 2022 +0000
tree 822488708d04b118a3dc2fb5fe6b59a071aac40a
parent 500411b77e88d80a4d38c7d816400d8f078b9ee8

dawn_node: Return undefined for "void" methods instead of null

Bug: dawn:1123
Change-Id: I38a5b160c12485ea23b34a6b3c8cdf44baee2ada
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/75903
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

src/dawn_node/interop/WebGPU.cpp.tmpl

diff --git a/src/dawn_node/interop/WebGPU.cpp.tmpl b/src/dawn_node/interop/WebGPU.cpp.tmpl
index d55dd3f..f70df8e 100644
--- a/src/dawn_node/interop/WebGPU.cpp.tmpl
+++ b/src/dawn_node/interop/WebGPU.cpp.tmpl
@@ -206,7 +206,7 @@
 {{-      if not (IsUndefinedType $o.Type) }}auto result = {{end -}}
           impl->{{$o.Name}}(info.Env(){{range $i, $_ := $o.Parameters}}, std::get<{{$i}}>(args){{end}});
           {{/* indent */ -}}
-{{-      if   IsUndefinedType $o.Type}}return info.Env().Null();
+{{-      if   IsUndefinedType $o.Type}}return info.Env().Undefined();
 {{-      else                        }}return ToJS(info.Env(), result);
 {{-      end                         }}
         }