Google Git
Sign in
dawn/dawn/0f9fccca069c124e286b02534a355f4456020984
commit
0f9fccca069c124e286b02534a355f4456020984
[log]
author
Kai Ninomiya <kainino@chromium.org>
Wed Feb 25 15:15:08 2026 -0800
committer
Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com>
Wed Feb 25 15:15:08 2026 -0800
tree
a3713effa41313297432cbaf31673e85a6bb9d54
parent
80b6775ff72756970afe1c725acc11164bf8544d [diff]
[dawn][metal] ArgBufs: fix refcounting in BindGroupLayoutMTL

- [NSArray arrayWithObjects] allocates an autoreleased array (per docs),
  so we don't need to acquire it. Since it's a local object, we also
  don't need an NSRef. Also add an @autoreleasepool to make it get freed
  immediately (instead of using whatever autoreleasepool is currently on
  the stack).
  - Note: LLDB and ASan were useless in debugging this. I found the
    environment variable NSZombieEnabled=YES which helped figure out
    which object it was:
      -[__NSSingleObjectArrayI release]: message sent to deallocated instance
- [MTLDevice newArgumentEncoderWithArguments] was leaking because of a
  missing AcquireNSPRef. ("new" apparently means it's not autoreleased.)
  - Debugged this using an ASan build and ASAN_OPTIONS=detect_leaks=1

Test: MultithreadCachingTests.RefAndReleaseCachedBindGroupLayoutsInParallel
Bug: 363031535
Change-Id: Id70f3bab4c239f4008e7fa031910addede22df48
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/292656
Reviewed-by: dan sinclair <dsinclair@chromium.org>
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
2 files changed
tree: a3713effa41313297432cbaf31673e85a6bb9d54
  1. .github/
  2. .vscode/
  3. build_overrides/
  4. docs/
  5. generator/
  6. include/
  7. infra/
  8. scripts/
  9. src/
  10. test/
  11. third_party/
  12. tools/
  13. webgpu-cts/
  14. build
  15. buildtools
  16. testing
  17. .bazelrc
  18. .clang-format
  19. .clang-format-ignore
  20. .clang-tidy
  21. .git-blame-ignore-revs
  22. .gitattributes
  23. .gitignore
  24. .gitmodules
  25. .gn
  26. .style.yapf
  27. .vpython3
  28. AUTHORS
  29. BUILD.bazel
  30. BUILD.gn
  31. CMakeLists.txt
  32. CMakeSettings.json
  33. CODE_OF_CONDUCT.md
  34. codereview.settings
  35. CONTRIBUTING.md
  36. CPPLINT.cfg
  37. DEPS
  38. DIR_METADATA
  39. go.mod
  40. go.sum
  41. go_presubmit_support.py
  42. LICENSE
  43. OWNERS
  44. PRESUBMIT.py
  45. README.chromium
  46. README.md
  47. test_spec_presubmit_support.py
  48. unsafe_buffers_paths.txt
  49. WATCHLISTS
  50. WORKSPACE.bazel
README.md

Build Status Matrix Space

Dawn, a WebGPU implementation

Dawn is an open-source and cross-platform implementation of the WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.

Dawn provides several WebGPU building blocks:

  • WebGPU C/C++ headers that applications and other building blocks use.
    • The webgpu.h version that Dawn implements.
    • A C++ wrapper for the webgpu.h.
  • A “native” implementation of WebGPU using platforms' GPU APIs: D3D12, Metal, Vulkan and OpenGL. See per API support for more details.
  • A client-server implementation of WebGPU for applications that are in a sandbox without access to native drivers
  • Tint is a compiler for the WebGPU Shader Language (WGSL) that can be used in standalone to convert shaders from and to WGSL.

Helpful links:

Documentation table of content

Developer documentation:

User documentation: (TODO, figure out what overlaps with the webgpu.h docs)

License

BSD 3-Clause License, please see LICENSE.

Disclaimer

This is not an officially supported Google product.