Google Git
Sign in
dawn / dawn / 1026cc1563fbf0f80a48e01e9571059021104112
commit1026cc1563fbf0f80a48e01e9571059021104112[log] [tgz]
authorStephen White <senorblanco@chromium.org>Tue Aug 13 18:23:20 2024 +0000
committerDawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Aug 13 18:23:20 2024 +0000
tree51084ecaf85466ed9c14e9a905d8e173696d6bc7
parent672e7bd198f43c70accdd94a85bdfa1842e2a466 [diff]
Fix texture-only arg in combine samplers transform.

When a function has an unused texture-only or sampler-only argument,
and no used texture/sampler pairs, the CombineSamplers transform was
failing to remove it from the argument list. The reason is an
incorrect early-out when no texture/sampler pairs are found.

https://dawn-review.googlesource.com/c/dawn/+/154181 attempted to
fix this by adding the unused arguments back as texture/sampler
solo pairs in CollectTextureSamplerPairs(). However, this is
problematic for a number of reasons.

This CL essentially reverts that change, and removes the incorrect
early-out, causing unused texture and sampler parameters to be
(correctly) removed.

Bug: chromium:356298370
Change-Id: If69e4d69dbf308637689622094193a285f9c3a46
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/202155
Reviewed-by: James Price <jrprice@google.com>
Commit-Queue: Stephen White <senorblanco@chromium.org>
5 files changed
tree: 51084ecaf85466ed9c14e9a905d8e173696d6bc7
  1. .github/
  2. .vscode/
  3. build_overrides/
  4. docs/
  5. generator/
  6. include/
  7. infra/
  8. scripts/
  9. src/
  10. test/
  11. third_party/
  12. tools/
  13. webgpu-cts/
  14. build
  15. buildtools
  16. testing
  17. .bazelrc
  18. .clang-format
  19. .clang-tidy
  20. .gitattributes
  21. .gitignore
  22. .gitmodules
  23. .gn
  24. AUTHORS
  25. BUILD.bazel
  26. BUILD.gn
  27. CMakeLists.txt
  28. CMakeSettings.json
  29. CODE_OF_CONDUCT.md
  30. codereview.settings
  31. CONTRIBUTING.md
  32. CPPLINT.cfg
  33. DEPS
  34. DIR_METADATA
  35. go.mod
  36. go.sum
  37. go_presubmit_support.py
  38. LICENSE
  39. OWNERS
  40. PRESUBMIT.py
  41. README.chromium
  42. README.md
  43. WORKSPACE.bazel
README.md

Build Status Matrix Space

Dawn, a WebGPU implementation

Dawn is an open-source and cross-platform implementation of the WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.

Dawn provides several WebGPU building blocks:

  • WebGPU C/C++ headers that applications and other building blocks use.
    • The webgpu.h version that Dawn implements.
    • A C++ wrapper for the webgpu.h.
  • A “native” implementation of WebGPU using platforms' GPU APIs: D3D12, Metal, Vulkan and OpenGL. See per API support for more details.
  • A client-server implementation of WebGPU for applications that are in a sandbox without access to native drivers
  • Tint is a compiler for the WebGPU Shader Language (WGSL) that can be used in standalone to convert shaders from and to WGSL.

Helpful links:

Documentation table of content

Developer documentation:

User documentation: (TODO, figure out what overlaps with the webgpu.h docs)

License

BSD 3-Clause License, please see LICENSE.

Disclaimer

This is not an officially supported Google product.