commit 10c24684ab9cd1c747e251d7cb4590c43eecad6b
author Natasha Lee <natlee@microsoft.com> Thu Mar 28 22:49:53 2019 +0000
committer Commit Bot service account <commit-bot@chromium.org> Thu Mar 28 22:49:53 2019 +0000
tree 2350e5332df87ee3ad9ee947d6e4e21bfc6eeec3
parent 19179e180b2e04990a725b038782e40b80fa75f3

Fix use of uninitialized value in ValidateTextureViewDescriptor

ValidateTextureViewDescriptor was running into use of uninitialized
value. Fixing this by moving the texture state check below the texture
object check. This should validate the texture object before trying to
validate it's texture state.

Bug: chromium:947150
Change-Id: I9b41791bfb960fbe4873ba5fcadf046bd32e5853
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/6180
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Natasha Lee <natlee@microsoft.com>

src/dawn_native/Texture.cpp

diff --git a/src/dawn_native/Texture.cpp b/src/dawn_native/Texture.cpp
index 223d855..573269c 100644
--- a/src/dawn_native/Texture.cpp
+++ b/src/dawn_native/Texture.cpp
@@ -182,11 +182,12 @@
         if (descriptor->nextInChain != nullptr) {
             return DAWN_VALIDATION_ERROR("nextInChain must be nullptr");
         }
+
+        DAWN_TRY(device->ValidateObject(texture));
         if (texture->GetTextureState() == TextureBase::TextureState::Destroyed) {
             return DAWN_VALIDATION_ERROR("Destroyed texture used to create texture view");
         }
 
-        DAWN_TRY(device->ValidateObject(texture));
         DAWN_TRY(ValidateTextureViewDimension(descriptor->dimension));
         DAWN_TRY(ValidateTextureFormat(descriptor->format));