[dawn][metal] Fix robustness issues around buffer lengths being u32

On Metal, the sizes of storage buffers (and vertex buffers when
transformed into storage buffers for vertex pulling for robustness) are
passed to MSL in an array of u32 values. Thus, such bindings cannot be
larger than 4GiB-1.

There is no separate limit on vertex buffer binding size (as there is
for storage buffer bindings), so in order to make this safe - without
significantly changing how buffer sizes are passed - this also reduces
maxBufferSize by 4 bytes to 4GiB-4. This should have minimal impact on
apps, but in order to raise it back to 4GiB we can either:
- Pass buffer size minus one (i.e. the max byte index value) into the
  shader so the minus-one step doesn't have to happen inside the shader
- Or just pass sizes as u64.

The tests are verified to fail without the fix, with the exception of
VertexBuffer_ZeroSizeRemaining which exists to help test later when we
raise the limit again.

Test: MetalBufferRobustnessTest.*
Fixed: 488400770
Change-Id: I3b4207b63ba641271b098a964734f70446595814
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/295255
Reviewed-by: Loko Kung <lokokung@google.com>
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
9 files changed
tree: 219179f665fdfedc37ab0c0ea705551de7a78adb
  1. .github/
  2. .vscode/
  3. build_overrides/
  4. docs/
  5. generator/
  6. include/
  7. infra/
  8. scripts/
  9. src/
  10. test/
  11. third_party/
  12. tools/
  13. webgpu-cts/
  14. .bazelrc
  15. .clang-format
  16. .clang-format-ignore
  17. .clang-tidy
  18. .git-blame-ignore-revs
  19. .gitattributes
  20. .gitignore
  21. .gitmodules
  22. .gn
  23. .style.yapf
  24. .vpython3
  25. AUTHORS
  26. BUILD.bazel
  27. BUILD.gn
  28. CMakeLists.txt
  29. CMakeSettings.json
  30. CODE_OF_CONDUCT.md
  31. codereview.settings
  32. CONTRIBUTING.md
  33. CPPLINT.cfg
  34. DEPS
  35. DIR_METADATA
  36. go.mod
  37. go.sum
  38. go_presubmit_support.py
  39. LICENSE
  40. OWNERS
  41. PRESUBMIT.py
  42. README.chromium
  43. README.md
  44. test_spec_presubmit_support.py
  45. unsafe_buffers_paths.txt
  46. WATCHLISTS
  47. WORKSPACE.bazel
README.md

Build Status Matrix Space

Dawn, a WebGPU implementation

Dawn is an open-source and cross-platform implementation of the WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.

Dawn provides several WebGPU building blocks:

  • WebGPU C/C++ headers that applications and other building blocks use.
    • The webgpu.h version that Dawn implements.
    • A C++ wrapper for the webgpu.h.
  • A “native” implementation of WebGPU using platforms' GPU APIs: D3D12, Metal, Vulkan and OpenGL. See per API support for more details.
  • A client-server implementation of WebGPU for applications that are in a sandbox without access to native drivers
  • Tint is a compiler for the WebGPU Shader Language (WGSL) that can be used in standalone to convert shaders from and to WGSL.

Helpful links:

Documentation table of content

Developer documentation:

User documentation: (TODO, figure out what overlaps with the webgpu.h docs)

License

BSD 3-Clause License, please see LICENSE.

Disclaimer

This is not an officially supported Google product.