commit 17f204769ca03120203f72332550835c9d62c745
author dan sinclair <dsinclair@chromium.org> Thu Nov 10 18:23:41 2022 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Nov 10 18:23:41 2022 +0000
tree 6462ef267c1e59730742045ef2822d1acfff2685
parent b77332edd22fea10a6e145788bf54e9fa289341b

Make formatting an error on presubmit

Currently the presubmit will emit a warning if the formatting fails
but this is easy to miss as the bot goes green. This CL changes
the presubmit to make formatting an error so the issue will be
caught and fixedup before landing.

Change-Id: Ifb83d2a7e524fd086e86b47f7518fea1e65f6d3e
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/109563
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>

PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index ecd0c62..8e03359 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -131,10 +131,17 @@
     results = []
     results.extend(
         input_api.canned_checks.CheckChangedLUCIConfigs(input_api, output_api))
+
+    result_factory = output_api.PresubmitPromptWarning
+    if input_api.is_committing:
+        result_factory = output_api.PresubmitError
+
     results.extend(
-        input_api.canned_checks.CheckPatchFormatted(input_api,
-                                                    output_api,
-                                                    check_python=True))
+        input_api.canned_checks.CheckPatchFormatted(
+            input_api,
+            output_api,
+            check_python=True,
+            result_factory=result_factory))
     results.extend(
         input_api.canned_checks.CheckChangeHasDescription(
             input_api, output_api))