Google Git
Sign in
dawn/dawn/1ca50a97fb43b775e4bd518c1d448fb7af7d2cc2
commit
1ca50a97fb43b775e4bd518c1d448fb7af7d2cc2
[log]
author
Antonio Maiorano <amaiorano@google.com>
Tue Feb 03 11:08:58 2026 -0800
committer
Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com>
Tue Feb 03 11:08:58 2026 -0800
tree
4cac262b37e8cc4e40df9e3d784fd70bb092079e
parent
80f802c730506e3c816b1a395f811876d26637c0 [diff]
[native][d3d12] Fix potential GPU heap allocation bug

During BindGroupStateTracker::Apply, called per draw command, when
populating the shader-visible view and sampler heaps, if an earlier bind
group fails populating the heap, but a later one succeeds, we would
erroneously not AllocateAndSwitchShaderVisibleHeap.

This CL includes two tests to show this bug in action, one for the view
heap, and one for the sampler heap.

Also added a missing test for "SwitchOverSamplerHeap", similar to
"SwitchOverViewHeap".

Bug: 481048333
Change-Id: Iddbae5b7383a5d036ab772f96788fd9332131b80
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/287395
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2 files changed
tree: 4cac262b37e8cc4e40df9e3d784fd70bb092079e
  1. .github/
  2. .vscode/
  3. build_overrides/
  4. docs/
  5. generator/
  6. include/
  7. infra/
  8. scripts/
  9. src/
  10. test/
  11. third_party/
  12. tools/
  13. webgpu-cts/
  14. build
  15. buildtools
  16. testing
  17. .bazelrc
  18. .clang-format
  19. .clang-format-ignore
  20. .clang-tidy
  21. .git-blame-ignore-revs
  22. .gitattributes
  23. .gitignore
  24. .gitmodules
  25. .gn
  26. .style.yapf
  27. .vpython3
  28. AUTHORS
  29. BUILD.bazel
  30. BUILD.gn
  31. CMakeLists.txt
  32. CMakeSettings.json
  33. CODE_OF_CONDUCT.md
  34. codereview.settings
  35. CONTRIBUTING.md
  36. CPPLINT.cfg
  37. DEPS
  38. DIR_METADATA
  39. go.mod
  40. go.sum
  41. go_presubmit_support.py
  42. LICENSE
  43. OWNERS
  44. PRESUBMIT.py
  45. README.chromium
  46. README.md
  47. test_spec_presubmit_support.py
  48. unsafe_buffers_paths.txt
  49. WATCHLISTS
  50. WORKSPACE.bazel
README.md

Build Status Matrix Space

Dawn, a WebGPU implementation

Dawn is an open-source and cross-platform implementation of the WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.

Dawn provides several WebGPU building blocks:

  • WebGPU C/C++ headers that applications and other building blocks use.
    • The webgpu.h version that Dawn implements.
    • A C++ wrapper for the webgpu.h.
  • A “native” implementation of WebGPU using platforms' GPU APIs: D3D12, Metal, Vulkan and OpenGL. See per API support for more details.
  • A client-server implementation of WebGPU for applications that are in a sandbox without access to native drivers
  • Tint is a compiler for the WebGPU Shader Language (WGSL) that can be used in standalone to convert shaders from and to WGSL.

Helpful links:

Documentation table of content

Developer documentation:

User documentation: (TODO, figure out what overlaps with the webgpu.h docs)

License

BSD 3-Clause License, please see LICENSE.

Disclaimer

This is not an officially supported Google product.