Google Git
Sign in
dawn/dawn/229ce1442d4d6eb61b22db9c9e906f1389aca504
commit
229ce1442d4d6eb61b22db9c9e906f1389aca504
[log]
author
Antonio Maiorano <amaiorano@google.com>
Thu Apr 09 15:19:33 2026 -0700
committer
Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com>
Thu Apr 09 15:19:33 2026 -0700
tree
0f6202510458cf85942e0b259225b17a6e7c01e1
parent
41e8b55388982b9c2e83f62e9ab47341a59b2064 [diff]
[native][d3d12] Fix non-visible samplers being counted in SamplerHeapCache

The SamplerHeapCache key is made up of all visible samplers in a
bind group; however, we were erroneously including non-visible ones.
This would result in OOB accesses in some places, such as in the
SamplerHeapCache destructor, where it uses the total number of samplers
to fetch the sampler allocator, but if this value is >
kMaxSamplerDescriptorsPerBindGroup (48), it would result in an OOB
vector access.

Note that this was missed as part of
https://dawn-review.git.corp.google.com/c/dawn/+/295955, which modified
the code to skip non-visible bind group entries. Tests were added that
created kMaxBindingsPerBindGroup (1000) non-visible bindings; but the
SamplerHeapCache code is skipped if there are no-visible samplers. So I
updated these tests to also include 1 visible sampler, which tripped the
aforementioned OOB accesses.

The fix is to make sure we only count visible samplers when creating the
SamplerHeapCache key.

Bug: 500441331
Change-Id: Id673c8ebf7ab2486c1d6c3232bc1ea3fe6f57df1
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/301695
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
Reviewed-by: Loko Kung <lokokung@google.com>
2 files changed
tree: 0f6202510458cf85942e0b259225b17a6e7c01e1
  1. .github/
  2. .vscode/
  3. build_overrides/
  4. docs/
  5. generator/
  6. include/
  7. infra/
  8. scripts/
  9. src/
  10. test/
  11. third_party/
  12. tools/
  13. webgpu-cts/
  14. build
  15. buildtools
  16. testing
  17. .bazelrc
  18. .clang-format
  19. .clang-format-ignore
  20. .clang-tidy
  21. .git-blame-ignore-revs
  22. .gitattributes
  23. .gitignore
  24. .gitmodules
  25. .gn
  26. .style.yapf
  27. .vpython3
  28. AUTHORS
  29. BUILD.bazel
  30. BUILD.gn
  31. CMakeLists.txt
  32. CMakeSettings.json
  33. CODE_OF_CONDUCT.md
  34. codereview.settings
  35. CONTRIBUTING.md
  36. CPPLINT.cfg
  37. DEPS
  38. DIR_METADATA
  39. go.mod
  40. go.sum
  41. go_presubmit_support.py
  42. LICENSE
  43. OWNERS
  44. PRESUBMIT.py
  45. README.chromium
  46. README.md
  47. unsafe_buffers_paths.txt
  48. WATCHLISTS
  49. WORKSPACE.bazel
README.md

Build Status Matrix Space

Dawn, a WebGPU implementation

Dawn is an open-source and cross-platform implementation of the WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.

Dawn provides several WebGPU building blocks:

  • WebGPU C/C++ headers that applications and other building blocks use.
    • The webgpu.h version that Dawn implements.
    • A C++ wrapper for the webgpu.h.
  • A “native” implementation of WebGPU using platforms' GPU APIs: D3D12, Metal, Vulkan and OpenGL. See per API support for more details.
  • A client-server implementation of WebGPU for applications that are in a sandbox without access to native drivers
  • Tint is a compiler for the WebGPU Shader Language (WGSL) that can be used in standalone to convert shaders from and to WGSL.

Helpful links:

Documentation table of content

Developer documentation:

User documentation: (TODO, figure out what overlaps with the webgpu.h docs)

License

BSD 3-Clause License, please see LICENSE.

Disclaimer

This is not an officially supported Google product.