commit 2828f35a71358117b5848cc48e9387380a5a2aa1
author Ben Clayton <bclayton@google.com> Tue Jul 06 10:49:50 2021 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Jul 06 10:49:50 2021 +0000
tree 12e6105b5ea7632639cbcbb534d9636b0d66149c
parent 435ebfcc40a249b3346bf2684b20ce091396a61d

D3D12: Re-enable FXC tests

Enough FXC workaround have been added to tint that these tests now pass again.

Fixed: tint:904
Change-Id: I6dd355d131ab903ae579391c0bfce93979dfc4f1
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/57041
Commit-Queue: Ben Clayton <bclayton@google.com>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Auto-Submit: Ben Clayton <bclayton@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

src/tests/end2end/VertexFormatTests.cpp

diff --git a/src/tests/end2end/VertexFormatTests.cpp b/src/tests/end2end/VertexFormatTests.cpp
index e735142..932e684 100644
--- a/src/tests/end2end/VertexFormatTests.cpp
+++ b/src/tests/end2end/VertexFormatTests.cpp
@@ -52,9 +52,6 @@
         // TODO(crbug.com/dawn/259): Failing because of a SPIRV-Cross issue.
         DAWN_SUPPRESS_TEST_IF(IsMetal() && IsIntel());
 
-        // TODO(crbug.com/tint/904): FXC emits bad output for this test
-        DAWN_SUPPRESS_TEST_IF(IsD3D12() && !IsDXC() && HasToggleEnabled("use_tint_generator"));
-
         renderPass = utils::CreateBasicRenderPass(device, kRTSize, kRTSize);
     }
 

src/tests/perf_tests/ShaderRobustnessPerf.cpp

diff --git a/src/tests/perf_tests/ShaderRobustnessPerf.cpp b/src/tests/perf_tests/ShaderRobustnessPerf.cpp
index c279ead..36d1e25 100644
--- a/src/tests/perf_tests/ShaderRobustnessPerf.cpp
+++ b/src/tests/perf_tests/ShaderRobustnessPerf.cpp
@@ -409,9 +409,6 @@
     // TODO(crbug.com/dawn/786): D3D12_Microsoft_Basic_Render_Driver_CPU
     DAWN_SUPPRESS_TEST_IF(IsD3D12() && IsWARP());
 
-    // TODO(crbug.com/tint/904): FXC emits bad output for this test
-    DAWN_SUPPRESS_TEST_IF(IsD3D12() && !IsDXC() && HasToggleEnabled("use_tint_generator"));
-
     // TODO(crbug.com/dawn/945): Generation via SPIRV-Cross fails
     DAWN_SUPPRESS_TEST_IF(IsOpenGL() || !HasToggleEnabled("use_tint_generator"));