commit 2a5fd58832cb577223490255cddb601063424e3d
author Austin Eng <enga@chromium.org> Tue Jun 29 17:29:23 2021 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Jun 29 17:29:23 2021 +0000
tree 8c5861c197132efa69105302bcf25ff902fc9823
parent 3194a08615c010ad0cd829f994da8ee7654f74cb

Remove double test instantiation with/without use_tint_generator

The test bots now instantiate separate test suites with/without
this toggle.

Bug: dawn:571
Change-Id: Ib4e8e89ac347d0030b233d1a3b14b318aa862aa6
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/56440
Commit-Queue: Austin Eng <enga@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Auto-Submit: Austin Eng <enga@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

src/tests/DawnTest.cpp

diff --git a/src/tests/DawnTest.cpp b/src/tests/DawnTest.cpp
index 697ad2f..9c44378 100644
--- a/src/tests/DawnTest.cpp
+++ b/src/tests/DawnTest.cpp
@@ -549,21 +549,6 @@
             if (params[i].backendType == adapterProperties.backendType &&
                 adapterProperties.selected) {
                 testParams.push_back(AdapterTestParam(params[i], adapterProperties));
-
-                // HACK: This is a hack to get Tint generator enabled on all tests
-                // without adding a new test suite in Chromium's infra config but skipping
-                // that suite on all unsupported platforms. Once we have basic functionality and
-                // test skips on all backends, we can remove this and use a test suite with
-                // use_tint_generator in the command line args instead.
-                if (params[i].backendType == wgpu::BackendType::Vulkan ||
-                    params[i].backendType == wgpu::BackendType::D3D12 ||
-                    params[i].backendType == wgpu::BackendType::Metal ||
-                    params[i].backendType == wgpu::BackendType::OpenGL ||
-                    params[i].backendType == wgpu::BackendType::OpenGLES) {
-                    BackendTestConfig configWithTint = params[i];
-                    configWithTint.forceEnabledWorkarounds.push_back("use_tint_generator");
-                    testParams.push_back(AdapterTestParam(configWithTint, adapterProperties));
-                }
             }
         }
     }