Google Git Google Git
Sign in
dawn/dawn/2afd6c8a512fed7956c8d2579e10c2209b23960d
commit
2afd6c8a512fed7956c8d2579e10c2209b23960d
[log]
author
Lokbondo Kung <lokokung@google.com>
Wed Oct 21 00:17:20 2026 -0700
committer
dawn-scoped@luci-project-accounts.iam.gserviceaccount.com <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com>
Wed Oct 21 00:17:20 2026 -0700
tree
53d6f195c1b3b56467d5dae3affc2ebb7c42ed76
parent
374440a9130dce680dacd3b27bf13e9c8f7c27e7 [diff] 
[security] Make sure that mPipeline in CreatePipelineEvent is cleared.

- As per the bug below, the mPipeline reference may live if an error
  occurs as a part of initializing the pipeline. Because we still hold
  a reference to the resulting pipeline in the error case, we can run
  into a teardown race where we reference the Vulkan object when it is
  no longer valid.
- This change just ensures that we always move the member variable out
  after the Complete call while holding the device lock.
- Update existing tests to verify the fix. Note that the crucial change
  to the test is to pass Ref<PipelineMock> with std::move so that the
  last reference is dropped the way it would be in actual production.

Bug: 575150692
Change-Id: Id1497f9fde96595bdba3b675415d2f07bc709a73
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/352215
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Auto-Submit: Loko Kung <lokokung@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2 files changed
tree: 53d6f195c1b3b56467d5dae3affc2ebb7c42ed76
  1. .github/
  2. .vscode/
  3. agents/
  4. build_overrides/
  5. docs/
  6. generator/
  7. include/
  8. infra/
  9. scripts/
  10. src/
  11. test/
  12. third_party/
  13. tools/
  14. webgpu-cts/
  15. build
  16. buildtools
  17. testing
  18. .bazelignore
  19. .bazelrc
  20. .bazelversion
  21. .clang-format
  22. .clang-format-ignore
  23. .clang-tidy
  24. .git-blame-ignore-revs
  25. .gitattributes
  26. .gitignore
  27. .gitmodules
  28. .gn
  29. .style.yapf
  30. AUTHORS
  31. BUILD.bazel
  32. BUILD.gn
  33. CMakeLists.txt
  34. CMakeSettings.json
  35. CODE_OF_CONDUCT.md
  36. codereview.settings
  37. CONTRIBUTING.md
  38. CPPLINT.cfg
  39. DEPS
  40. DIR_METADATA
  41. go.mod
  42. go.sum
  43. go_presubmit_support.py
  44. LICENSE
  45. MODULE.bazel
  46. OWNERS
  47. PRESUBMIT.py
  48. PRESUBMIT_test.py
  49. README.chromium
  50. README.md
  51. unsafe_buffers_paths.txt
  52. vpython.toml
  53. vpython.toml.uv.lock
  54. WATCHLISTS
  55. WORKSPACE.bazel
README.md

Build Status Matrix Space

Dawn, a WebGPU implementation

Dawn is an open-source and cross-platform implementation of the WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.

Dawn provides several WebGPU building blocks:

  • WebGPU C/C++ headers that applications and other building blocks use.
    • The webgpu.h version that Dawn implements.
    • A C++ wrapper for the webgpu.h.
  • A “native” implementation of WebGPU using platforms' GPU APIs: D3D12, Metal, Vulkan and OpenGL. See per API support for more details.
  • A client-server implementation of WebGPU for applications that are in a sandbox without access to native drivers
  • Tint is a compiler for the WebGPU Shader Language (WGSL) that can be used in standalone to convert shaders from and to WGSL.

Helpful links:

Documentation table of content

Developer documentation:

User documentation: (TODO, figure out what overlaps with the webgpu.h docs)

License

BSD 3-Clause License, please see LICENSE.

Disclaimer

This is not an officially supported Google product.