commit 2b9d702c09f19966bdc07758893976e90f8be7cf
author Yunchao He <yunchao.he@intel.com> Thu Jan 03 09:00:34 2019 +0000
committer Commit Bot service account <commit-bot@chromium.org> Thu Jan 03 09:00:34 2019 +0000
tree 74003d4ee4cf2a7d9d0cd57500c33542ed2922c2
parent d238bb67a52a6b940dd8299675c368230d2c7064

Fix a bug for depth test on Vulkan backend

The default value for maxDepthBound should be 1.0.

BUG=dawn:81

Change-Id: I337aac884456c739222bc31f8003267aa6de96af
Reviewed-on: https://dawn-review.googlesource.com/c/3580
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Yunchao He <yunchao.he@intel.com>

src/dawn_native/vulkan/DepthStencilStateVk.cpp

diff --git a/src/dawn_native/vulkan/DepthStencilStateVk.cpp b/src/dawn_native/vulkan/DepthStencilStateVk.cpp
index c2f29a4..2f6472c 100644
--- a/src/dawn_native/vulkan/DepthStencilStateVk.cpp
+++ b/src/dawn_native/vulkan/DepthStencilStateVk.cpp
@@ -74,12 +74,16 @@
         mCreateInfo.flags = 0;
 
         const auto& depth = GetDepth();
-        mCreateInfo.depthTestEnable = VK_TRUE;
+        // Depth writes only occur if depth is enabled
+        mCreateInfo.depthTestEnable =
+            (depth.compareFunction == dawn::CompareFunction::Always && !depth.depthWriteEnabled)
+                ? VK_FALSE
+                : VK_TRUE;
         mCreateInfo.depthWriteEnable = depth.depthWriteEnabled ? VK_TRUE : VK_FALSE;
         mCreateInfo.depthCompareOp = VulkanCompareOp(depth.compareFunction);
         mCreateInfo.depthBoundsTestEnable = false;
         mCreateInfo.minDepthBounds = 0.0f;
-        mCreateInfo.maxDepthBounds = 0.0f;
+        mCreateInfo.maxDepthBounds = 1.0f;
 
         const auto& stencil = GetStencil();
         mCreateInfo.stencilTestEnable = StencilTestEnabled() ? VK_TRUE : VK_FALSE;