Google Git
Sign in
dawn / dawn / 2d501c5575e62e0a813c077d8fa6182bc7cc4496
commit2d501c5575e62e0a813c077d8fa6182bc7cc4496[log] [tgz]
authorBen Clayton <bclayton@google.com>Wed Jan 17 01:27:37 2024 +0000
committerDawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Jan 17 01:27:37 2024 +0000
treee9bb1fa1db47a626d1a6d1e1d7078bcee4036446
parent93140ed00ca592168192bd0822040c4f7fcefea6 [diff]
[tint] Fix emission of module-scope struct initializers

Constant structure initializers need to be assigned directly to a
variable in HLSL. We were emitting these as `const` variables for both
module-scope and function-scope.

Module-scope `const` variables are not held in the program bitcode, but
are expected to be provided as a cbuffer binding, which dawn was not
providing.

Instead emit these always as global scope `static const` variables.

Add a dawn end2end test for `var<private>` variables initialized with a
`struct`

Bug: tint:2142
Change-Id: I03c7c94a1729dcfbc077bcef01495a9fbbff0290
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/169940
Commit-Queue: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
18 files changed
tree: e9bb1fa1db47a626d1a6d1e1d7078bcee4036446
  1. .github/
  2. .vscode/
  3. build_overrides/
  4. docs/
  5. generator/
  6. include/
  7. infra/
  8. scripts/
  9. src/
  10. test/
  11. third_party/
  12. tools/
  13. webgpu-cts/
  14. build
  15. buildtools
  16. testing
  17. .bazelrc
  18. .clang-format
  19. .clang-tidy
  20. .gitattributes
  21. .gitignore
  22. .gitmodules
  23. .gn
  24. AUTHORS
  25. BUILD.bazel
  26. BUILD.gn
  27. CMakeLists.txt
  28. CMakeSettings.json
  29. CODE_OF_CONDUCT.md
  30. codereview.settings
  31. CONTRIBUTING.md
  32. CPPLINT.cfg
  33. DEPS
  34. DIR_METADATA
  35. Doxyfile
  36. go.mod
  37. go.sum
  38. go_presubmit_support.py
  39. LICENSE
  40. OWNERS
  41. PRESUBMIT.py
  42. README.chromium
  43. README.md
  44. WORKSPACE.bazel
README.md

Build Status Matrix Space

Dawn, a WebGPU implementation

Dawn is an open-source and cross-platform implementation of the WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.

Dawn provides several WebGPU building blocks:

  • WebGPU C/C++ headers that applications and other building blocks use.
    • The webgpu.h version that Dawn implements.
    • A C++ wrapper for the webgpu.h.
  • A “native” implementation of WebGPU using platforms' GPU APIs: D3D12, Metal, Vulkan and OpenGL. See per API support for more details.
  • A client-server implementation of WebGPU for applications that are in a sandbox without access to native drivers
  • Tint is a compiler for the WebGPU Shader Language (WGSL) that can be used in standalone to convert shaders from and to WGSL.

Helpful links:

Documentation table of content

Developer documentation:

User documentation: (TODO, figure out what overlaps with the webgpu.h docs)

License

BSD 3-Clause License, please see LICENSE.

Disclaimer

This is not an officially supported Google product.