commit 2f022078057366c369d155dbd642b398ad5a018d
author Austin Eng <enga@chromium.org> Wed Jun 03 16:43:35 2020 +0000
committer Commit Bot service account <commit-bot@chromium.org> Wed Jun 03 16:43:35 2020 +0000
tree ac8d499e4cc23ddb576c1e39e54fe0c589c439f3
parent 0768ffa7422036bd2684f17ebb899d8163451e61

Generate specific error when BGL storageTextureFormat is missing

Some WebGPU CTS tests were failing with invalid WGPUTextureFormat
when really the format was simply missing. This CL updates
the validation code so it is more clear.

Bug: dawn:433
Change-Id: Ie7aacd01ea424d9f5df0078703a474e98b72ce41
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/22543
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Stephen White <senorblanco@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>

src/dawn_native/BindGroupLayout.cpp

diff --git a/src/dawn_native/BindGroupLayout.cpp b/src/dawn_native/BindGroupLayout.cpp
index a7d19fb..eb2cd06 100644
--- a/src/dawn_native/BindGroupLayout.cpp
+++ b/src/dawn_native/BindGroupLayout.cpp
@@ -68,6 +68,9 @@
         switch (bindingType) {
             case wgpu::BindingType::ReadonlyStorageTexture:
             case wgpu::BindingType::WriteonlyStorageTexture: {
+                if (storageTextureFormat == wgpu::TextureFormat::Undefined) {
+                    return DAWN_VALIDATION_ERROR("Storage texture format is missing");
+                }
                 DAWN_TRY(ValidateTextureFormat(storageTextureFormat));
 
                 const Format* format = nullptr;