commit | 37780d2179655867ec3f483965916f0669fdfe74 | [log] [tgz] |
---|---|---|
author | Brian Sheedy <bsheedy@google.com> | Thu Feb 08 03:31:41 2024 +0000 |
committer | Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Feb 08 03:31:41 2024 +0000 |
tree | f55e72352cd958eff8ba6f0cf693b5951194cf45 | |
parent | 95cada18965836843ef1ee92cffeed6623adb2d5 [diff] |
Revert "[toggles] Set labels on backend objects only if toggle is set" This reverts commit e3a55c65bb66bfabb65de7bd69ee062b02bbe911. Reason for revert: Causing issues on NVIDIA Shield TV devices crbug.com/324282958 Original change's description: > [toggles] Set labels on backend objects only if toggle is set > > We have found that in Chrome, setting these labels can be a source of > non-trivial overhead on performance benchmarks. This CL guards setting > of these labels with the `use_user_defined_labels_in_backend` toggle. > Note that labels will still be set on frontend objects, and hence will > still be available in e.g. Dawn error messages. The labels on the > backend objects are relevant only when debugging via platform-specific > facilities (e.g., XCode). > > This CL also changes the `use_user_defined_labels_in_backend` toggle to > default to true if validation is enabled. This is necessary as at least > on Vulkan Dawn's debugging facilities assume that these labels are > set [1]. It is consistent in any case, as a client enabling validation > indicates that they are more concerned about debuggability than > performance. > > [1] https://source.chromium.org/chromium/chromium/src/+/main:third_party/dawn/src/dawn/native/vulkan/BackendVk.cpp;l=263?q=BackendVk.cpp&ss=chromium > > Change-Id: I46fd862382f89e61588535c16daeba976d45825e > Bug: dawn:2383 > Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/172861 > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Kokoro: Kokoro <noreply+kokoro@google.com> > Commit-Queue: Colin Blundell <blundell@chromium.org> # Not skipping CQ checks because original CL landed > 1 day ago. Bug: dawn:2383, chromium:324282958 Change-Id: I1669fce616eaa4c76d3bd4d9ddd1bac7ad86b19d Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/173849 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Dawn is an open-source and cross-platform implementation of the WebGPU standard. More precisely it implements webgpu.h
that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.
Dawn provides several WebGPU building blocks:
webgpu.h
version that Dawn implements.webgpu.h
.Helpful links:
Developer documentation:
User documentation: (TODO, figure out what overlaps with the webgpu.h docs)
BSD 3-Clause License, please see LICENSE.
This is not an officially supported Google product.