Fix MapAsyncAndWait use-after-free

Fixes an issue where the callback registered in
DawnTestBase::MapAsyncAndWait could cause an access violation during
global test teardown due to trying to run a callback that was allocated
on the stack and had already gone out of scope. This only occurred when
instance.WaitAny() timed out, which would cause the callback to still
be around until the instance got destroyed and ensured that all pending
callbacks were complete.

Now, the actual callback to run is provided via a shared_ptr and the
lambda provided to buffer.MapAsync() checks if it is null before running
it. After instance.WaitAny() returns but before we make any asserts, we
set the pointer to null, preventing the soon-to-be-dangling pointer from
being used in the future.

This is meant as a temporary workaround, as WaitAny() should always run
the provided callback. This can be reverted once the underlying issue
is fixed.

Bug: 459864803, 460743383
Change-Id: I5384e74ff6ab9da6104b07e6d9d235bf5d4b40c2
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/273736
Commit-Queue: Brian Sheedy <bsheedy@google.com>
Reviewed-by: Loko Kung <lokokung@google.com>
Auto-Submit: Brian Sheedy <bsheedy@google.com>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
1 file changed
tree: 6322db829bd51cb929c1eafa9c37fc18b3fd7ff4
  1. .github/
  2. .vscode/
  3. build_overrides/
  4. docs/
  5. generator/
  6. include/
  7. infra/
  8. scripts/
  9. src/
  10. test/
  11. third_party/
  12. tools/
  13. webgpu-cts/
  14. .bazelrc
  15. .clang-format
  16. .clang-format-ignore
  17. .clang-tidy
  18. .git-blame-ignore-revs
  19. .gitattributes
  20. .gitignore
  21. .gitmodules
  22. .gn
  23. .style.yapf
  24. .vpython3
  25. AUTHORS
  26. BUILD.bazel
  27. BUILD.gn
  28. CMakeLists.txt
  29. CMakeSettings.json
  30. CODE_OF_CONDUCT.md
  31. codereview.settings
  32. CONTRIBUTING.md
  33. CPPLINT.cfg
  34. DEPS
  35. DIR_METADATA
  36. go.mod
  37. go.sum
  38. go_presubmit_support.py
  39. LICENSE
  40. OWNERS
  41. PRESUBMIT.py
  42. README.chromium
  43. README.md
  44. unsafe_buffers_paths.txt
  45. WATCHLISTS
  46. WORKSPACE.bazel
README.md

Build Status Matrix Space

Dawn, a WebGPU implementation

Dawn is an open-source and cross-platform implementation of the WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.

Dawn provides several WebGPU building blocks:

  • WebGPU C/C++ headers that applications and other building blocks use.
    • The webgpu.h version that Dawn implements.
    • A C++ wrapper for the webgpu.h.
  • A “native” implementation of WebGPU using platforms' GPU APIs: D3D12, Metal, Vulkan and OpenGL. See per API support for more details.
  • A client-server implementation of WebGPU for applications that are in a sandbox without access to native drivers
  • Tint is a compiler for the WebGPU Shader Language (WGSL) that can be used in standalone to convert shaders from and to WGSL.

Helpful links:

Documentation table of content

Developer documentation:

User documentation: (TODO, figure out what overlaps with the webgpu.h docs)

License

BSD 3-Clause License, please see LICENSE.

Disclaimer

This is not an officially supported Google product.