commit 3f24fdc4476023b30a3a00793391a70bac0379db
author Ben Clayton <bclayton@google.com> Tue Nov 01 00:23:14 2022 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Nov 01 00:23:14 2022 +0000
tree 47bcf11d9589f84ad90e7e97a0e8e47031aa9336
parent e689e053beef4c547aa468cfcc26bc80e2b73f46

tint/fuzzers: Don't run the inspector on invalid programs

docs/tint/arch.md states that:
> The input `Program` to the inspector must be valid (pass validation).

So it should not be assumed that the inspector can handle invalid programs.

Bug: chromium:1378999
Change-Id: I780f59ba1117f5eadb461a55947c8e36761ab25f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/107688
Commit-Queue: Ben Clayton <bclayton@google.com>
Auto-Submit: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>

src/tint/fuzzers/tint_common_fuzzer.cc

diff --git a/src/tint/fuzzers/tint_common_fuzzer.cc b/src/tint/fuzzers/tint_common_fuzzer.cc
index 9e12a12..1c24f35 100644
--- a/src/tint/fuzzers/tint_common_fuzzer.cc
+++ b/src/tint/fuzzers/tint_common_fuzzer.cc
@@ -303,6 +303,11 @@
     inspector::Inspector inspector(program);
     diagnostics_ = program->Diagnostics();
 
+    if (!program->IsValid()) {
+        // It's not safe to use the inspector on invalid programs.
+        return;
+    }
+
     auto entry_points = inspector.GetEntryPoints();
     CHECK_INSPECTOR(program, inspector);